rustbuild: Add option for enabling partial LLVM rebuilds #40329
Conversation
|
Oh sorry I did indeed miss that, my bad! FWIW I'm down for basically any behavior that's reasonable for local development. Local developers are much more forgiving with behavior like "looks weird? eh I'll blow it away". CI is much more unforgiving :( That being said we're in a much better place than we were when all this infrastructure was created long ago. Almost all CI builders start from scratch unconditionally (e.g. no llvm build dir existing). We then rely on sccache to quickly compile LLVM (as it should all be cached). Unfortunately, though, sccache doesn't quite work on MSVC with LLVM just yet (effort to get ninja working hasn't completed yet). So to counter this the LLVM build directory is cached across MSVC builds on appveyor. For us though AppVeyor handles the invalidation by not downloading the cache when So the tl;dr; for CI is that:
For now that means that we still require (if you're willing to help out with sccache on ninja it'd be much appreciated as well!) |
|
This PR seems fine by me, but want to default this option to |
|
Updated. |
|
@bors: r+ |
|
📌 Commit 5697240 has been approved by |
|
🔒 Merge conflict |
|
@bors: retry |
|
@bors: r+ |
|
📌 Commit c4b9284 has been approved by |
|
@bors: r+ |
|
📌 Commit 8c5bdd6 has been approved by |
Rollup of 38 pull requests - Successful merges: #39202, #39820, #39918, #39921, #40092, #40146, #40199, #40225, #40239, #40257, #40259, #40261, #40277, #40278, #40287, #40297, #40311, #40315, #40319, #40324, #40336, #40340, #40344, #40345, #40367, #40369, #40372, #40373, #40379, #40385, #40386, #40389, #40400, #40404, #40410, #40422, #40423, #40424 - Failed merges: #40220, #40329, #40426
Rollup of 38 pull requests - Successful merges: #39202, #39820, #39918, #39921, #40092, #40146, #40199, #40225, #40239, #40257, #40259, #40261, #40277, #40278, #40287, #40297, #40311, #40315, #40319, #40324, #40336, #40340, #40344, #40345, #40367, #40369, #40372, #40373, #40379, #40385, #40386, #40389, #40400, #40404, #40410, #40422, #40423, #40424 - Failed merges: #40220, #40329, #40426
|
☔ The latest upstream changes (presumably #40432) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@bors r=alexcrichton |
|
📌 Commit 4cdbe5c has been approved by |
|
⌛ Testing commit 4cdbe5c with merge 4123c76... |
|
☔ The latest upstream changes (presumably #40257) made this pull request unmergeable. Please resolve the merge conflicts. |
It may not exist, so we don't want to spuriously generate an error.
|
@bors r=alexcrichton |
|
📌 Commit 4cda4d6 has been approved by |
|
⌛ Testing commit 4cda4d6 with merge 49ab594... |
|
💔 Test failed - status-travis |
|
Not sure what happened, too much logging from sccache, the part of the log after 4MB is lost. @bors retry |
|
⌛ Testing commit 4cda4d6 with merge 4ab92b8... |
|
💔 Test failed - status-appveyor |
|
sccache failure: @bors retry |
|
⌛ Testing commit 4cda4d6 with merge 2936719... |
|
💔 Test failed - status-appveyor |
|
sccache failure @bors retry |
|
⌛ Testing commit 4cda4d6 with merge 0a1bce1... |
|
💔 Test failed - status-travis |
|
@bors: retry
|
rustbuild: Add option for enabling partial LLVM rebuilds @alexcrichton , you probably didn't notice my [late comment](#40236 (comment)) on #40236, but here's an implementation of that suggestion, it supersedes c652a4f. r? @alexcrichton
|
☀️ Test successful - status-appveyor, status-travis |
@alexcrichton , you probably didn't notice my late comment on #40236, but here's an implementation of that suggestion, it supersedes c652a4f.
r? @alexcrichton