-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix indentation of error message #39940
Conversation
So I just encountered this error for the first time. It's unclear what it means, why I encountered it, or how to fix it. But worst of all, it has a random newline and weird indentation! This commit fixes that last bit.
(rust_highfive has picked a reviewer for you, use r? to override) |
@bors: r+ |
📌 Commit ec648a1 has been approved by |
Fix indentation of error message So I just encountered this error for the first time. It's unclear what it means, why I encountered it, or how to fix it. But worst of all, it has a random newline and weird indentation! This commit fixes that last bit. <img width="680" alt="screen shot 2017-02-18 at 4 35 36 pm" src="https://cloud.githubusercontent.com/assets/1529387/23097087/0ef5ac4a-f5f9-11e6-9132-18ce759f7092.png">
⌛ Testing commit ec648a1 with merge 1780ccb... |
💔 Test failed - status-travis |
@bors: retry
* network error
…On Sun, Feb 19, 2017 at 3:10 PM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/203243033>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#39940 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95HcxnoI-s57TKlELqNobHRVWcD70ks5reK-vgaJpZM4MFRC_>
.
|
@sgrif example code? it probably means you've got a recursive enum somewhere. |
@nikomatsakis The type is an hlist, which is recursive but not represented as an enum. The code this impl (but for a 16 element hlist/tuple instead of 2): impl<A, B, SqlA, SqlB, DB> Queryable<Cons<SqlA, Cons<SqlB, Nil>>, DB> for (A, B) where
DB: Backend + HasSqlType<SqlA> + HasSqlType<SqlB>,
DB: HasSqlType<Cons<SqlA, Cons<SqlB, Nil>>>,
A: Queryable<SqlA, DB>,
B: Queryable<SqlB, DB>,
Cons<A, Cons<B, Nil>>: FromSqlRow<Cons<SqlA, Cons<SqlB, Nil>>, DB>,
{
type Row = Cons<A, Cons<B, Nil>>;
fn build(Cons(a, Cons(b, Nil)): Self::Row) -> Self {
(a, b)
}
} We ended up dropping the max size we generate that impl for to 12, which resolved the issue. (We picked 12 arbitrarily because it's the largest tuple that libstd provides impls of things like |
@sgrif ah ok |
@nikomatsakis The error message should probably mention that |
Fix indentation of error message So I just encountered this error for the first time. It's unclear what it means, why I encountered it, or how to fix it. But worst of all, it has a random newline and weird indentation! This commit fixes that last bit. <img width="680" alt="screen shot 2017-02-18 at 4 35 36 pm" src="https://cloud.githubusercontent.com/assets/1529387/23097087/0ef5ac4a-f5f9-11e6-9132-18ce759f7092.png">
@bors: rollup |
Fix indentation of error message So I just encountered this error for the first time. It's unclear what it means, why I encountered it, or how to fix it. But worst of all, it has a random newline and weird indentation! This commit fixes that last bit. <img width="680" alt="screen shot 2017-02-18 at 4 35 36 pm" src="https://cloud.githubusercontent.com/assets/1529387/23097087/0ef5ac4a-f5f9-11e6-9132-18ce759f7092.png">
Fix indentation of error message So I just encountered this error for the first time. It's unclear what it means, why I encountered it, or how to fix it. But worst of all, it has a random newline and weird indentation! This commit fixes that last bit. <img width="680" alt="screen shot 2017-02-18 at 4 35 36 pm" src="https://cloud.githubusercontent.com/assets/1529387/23097087/0ef5ac4a-f5f9-11e6-9132-18ce759f7092.png">
Fix indentation of error message So I just encountered this error for the first time. It's unclear what it means, why I encountered it, or how to fix it. But worst of all, it has a random newline and weird indentation! This commit fixes that last bit. <img width="680" alt="screen shot 2017-02-18 at 4 35 36 pm" src="https://cloud.githubusercontent.com/assets/1529387/23097087/0ef5ac4a-f5f9-11e6-9132-18ce759f7092.png">
Fix indentation of error message So I just encountered this error for the first time. It's unclear what it means, why I encountered it, or how to fix it. But worst of all, it has a random newline and weird indentation! This commit fixes that last bit. <img width="680" alt="screen shot 2017-02-18 at 4 35 36 pm" src="https://cloud.githubusercontent.com/assets/1529387/23097087/0ef5ac4a-f5f9-11e6-9132-18ce759f7092.png">
So I just encountered this error for the first time. It's unclear what
it means, why I encountered it, or how to fix it. But worst of all, it
has a random newline and weird indentation! This commit fixes that last
bit.