Additional docs for Vec, String, and slice trait impls #39886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagisa
reviewed
Feb 16, 2017
src/libcollections/string.rs
Outdated
| /// every operation, which would lead to `O(n^2)` running time when building an `n`-byte string by | ||
| /// repeated concatenation. | ||
| /// | ||
| /// The string on the left is only borrowed; its contents are copied into the returned `String`. |
There was a problem hiding this comment.
“left-hand operand” may be a better way to name… operand on the left.
There was a problem hiding this comment.
Oops, also this sentence is supposed to be about the right-hand operand anyway.
|
@bors: r+ rollup looks great! |
|
📌 Commit b2ac1c9 has been approved by |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Feb 22, 2017
Additional docs for Vec, String, and slice trait impls r? @steveklabnik
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 23, 2017
Additional docs for Vec, String, and slice trait impls r? @steveklabnik
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Feb 23, 2017
Additional docs for Vec, String, and slice trait impls r? @steveklabnik
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 23, 2017
Additional docs for Vec, String, and slice trait impls r? @steveklabnik
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Feb 24, 2017
Additional docs for Vec, String, and slice trait impls r? @steveklabnik
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 24, 2017
Additional docs for Vec, String, and slice trait impls r? @steveklabnik
bors
added a commit
that referenced
this pull request
Feb 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @steveklabnik