Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use bash when invoking dist shell scripts on solaris #39857

Merged
merged 1 commit into from
Feb 16, 2017
Merged

use bash when invoking dist shell scripts on solaris #39857

merged 1 commit into from
Feb 16, 2017

Conversation

binarycrusader
Copy link
Contributor

Partially fixes #25845

A separate, trivial fix is needed to the rust-installer scripts to completely resolve this issue.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Feb 15, 2017

📌 Commit 087c233 has been approved by alexcrichton

@binarycrusader
Copy link
Contributor Author

Please excuse the last commit I added; I reverted it. I'm still learning the process of GitHub's pull requests. I didn't expect those commits to show up on this pull request.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Feb 16, 2017

📌 Commit 087c233 has been approved by alexcrichton

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 16, 2017
@frewsxcv
Rollup merge of rust-lang#39857 - binarycrusader:master, r=alexcrichton
88f40f7 
use bash when invoking dist shell scripts on solaris

Partially fixes rust-lang#25845

A separate, trivial fix is needed to the rust-installer scripts to completely resolve this issue.
@frewsxcv frewsxcv mentioned this pull request Feb 16, 2017
Merged
bors added a commit that referenced this pull request Feb 16, 2017
@bors
Auto merge of #39876 - frewsxcv:rollup, r=frewsxcv
d77af7f 
Rollup of 12 pull requests

- Successful merges: #39775, #39793, #39804, #39834, #39836, #39839, #39840, #39843, #39844, #39846, #39857, #39861
- Failed merges:
@bors bors merged commit 087c233 into rust-lang:master Feb 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

#!/bin/sh fails for Solaris
4 participants
@binarycrusader @rust-highfive @alexcrichton @bors