rustbuild: Add manifest generation in-tree #39284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
I don't currently have a plan to test this on Travis, unfortunately. I could imagine that we build a manifest for the previous commit, but I figure we can add that later if necessary. r? @brson |
38 tasks
alexcrichton
force-pushed
the
manifesting
branch
2 times, most recently
from
5ee5253
to
ed49cb7
Compare
|
☔ The latest upstream changes (presumably #39245) made this pull request unmergeable. Please resolve the merge conflicts. |
alexcrichton
force-pushed
the
manifesting
branch
from
ed49cb7
to
dc864a8
Compare
This commit adds a new tool, `build-manifest`, which is used to generate a distribution manifest of all produced artifacts. This tool is intended to replace the `build-rust-manifest.py` script that's currently located on the buildmaster. The intention is that we'll have a builder which periodically: * Downloads all artifacts for a commit * Runs `./x.py dist hash-and-sign`. This will generate `sha256` and `asc` files as well as TOML manifests. * Upload all generated hashes and manifests to the directory the artifacts came from. * Upload *all* artifacts (tarballs and hashes and manifests) to an archived location. * If necessary, upload all artifacts to the main location. This script is intended to just be the second step here where orchestrating uploads and such will all happen externally from the build system itself.
alexcrichton
force-pushed
the
manifesting
branch
from
dc864a8
to
9e8785f
Compare
nrc
reviewed
Jan 25, 2017
| self.package("cargo", &mut manifest.pkg, HOSTS); | ||
| self.package("rust-mingw", &mut manifest.pkg, MINGW); | ||
| self.package("rust-std", &mut manifest.pkg, TARGETS); | ||
| self.package("rust-docs", &mut manifest.pkg, TARGETS); |
There was a problem hiding this comment.
if we simply add rust-analysis here, will that get it manifested and known to rustup?
There was a problem hiding this comment.
I think we'd also need to add it to extensions below, but other than that I think that's it. @brson how do you feel about throwing that in here? currently this is mostly just a straight port of the python script on the buildmaster.
There was a problem hiding this comment.
I've submitted rust-lang-deprecated/rust-buildbot#150, so when that lands it would still be a straight port :-)
5 tasks
|
Looks great @bors r+ |
|
📌 Commit 9e8785f has been approved by |
bors
added a commit
that referenced
this pull request
Jan 27, 2017
rustbuild: Add manifest generation in-tree This commit adds a new tool, `build-manifest`, which is used to generate a distribution manifest of all produced artifacts. This tool is intended to replace the `build-rust-manifest.py` script that's currently located on the buildmaster. The intention is that we'll have a builder which periodically: * Downloads all artifacts for a commit * Runs `./x.py dist hash-and-sign`. This will generate `sha256` and `asc` files as well as TOML manifests. * Upload all generated hashes and manifests to the directory the artifacts came from. * Upload *all* artifacts (tarballs and hashes and manifests) to an archived location. * If necessary, upload all artifacts to the main location. This script is intended to just be the second step here where orchestrating uploads and such will all happen externally from the build system itself. cc #38531
|
💔 Test failed - status-travis |
|
@bors: retry
|
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Jan 28, 2017
rustbuild: Add manifest generation in-tree This commit adds a new tool, `build-manifest`, which is used to generate a distribution manifest of all produced artifacts. This tool is intended to replace the `build-rust-manifest.py` script that's currently located on the buildmaster. The intention is that we'll have a builder which periodically: * Downloads all artifacts for a commit * Runs `./x.py dist hash-and-sign`. This will generate `sha256` and `asc` files as well as TOML manifests. * Upload all generated hashes and manifests to the directory the artifacts came from. * Upload *all* artifacts (tarballs and hashes and manifests) to an archived location. * If necessary, upload all artifacts to the main location. This script is intended to just be the second step here where orchestrating uploads and such will all happen externally from the build system itself. cc rust-lang#38531
bors
added a commit
that referenced
this pull request
Jan 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new tool,
build-manifest, which is used to generate adistribution manifest of all produced artifacts. This tool is intended to
replace the
build-rust-manifest.pyscript that's currently located on thebuildmaster. The intention is that we'll have a builder which periodically:
./x.py dist hash-and-sign. This will generatesha256andascfilesas well as TOML manifests.
from.
location.
This script is intended to just be the second step here where orchestrating
uploads and such will all happen externally from the build system itself.
cc #38531