add test case for changing private methods #37124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelwoerister
approved these changes
Oct 17, 2016
| use point::Point; | ||
|
|
||
| // FIXME(#37121) -- we should not need to typeck this again | ||
| #[rustc_dirty(label="TypeckItemBody", cfg="rpass2")] |
There was a problem hiding this comment.
That fails too? Interesting.
| } | ||
| } | ||
|
|
||
| /// A fn item that reads fields from `Point` but does not invoke methods |
There was a problem hiding this comment.
The comment should probably say "write" instead of "read".
|
@bors r+ rollup |
|
📌 Commit c560ca4 has been approved by |
eddyb
added a commit
to eddyb/rust
that referenced
this pull request
Oct 19, 2016
…=michaelwoerister add test case for changing private methods The goal of this test case is to ensure we are getting the reuse we expect. This targets a particular change where we modify the body of a private inherent method defined on a struct, and looks at different ways we can use that struct. It checks for when type-checking would be needed as well as the actual reuse achieved. cc rust-lang#37121 r? @michaelwoerister
eddyb
added a commit
to eddyb/rust
that referenced
this pull request
Oct 19, 2016
…=michaelwoerister add test case for changing private methods The goal of this test case is to ensure we are getting the reuse we expect. This targets a particular change where we modify the body of a private inherent method defined on a struct, and looks at different ways we can use that struct. It checks for when type-checking would be needed as well as the actual reuse achieved. cc rust-lang#37121 r? @michaelwoerister
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this test case is to ensure we are getting the reuse we expect. This targets a particular change where we modify the body of a private inherent method defined on a struct, and looks at different ways we can use that struct.
It checks for when type-checking would be needed as well as the actual reuse achieved.
cc #37121
r? @michaelwoerister