Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

normalize tuple pair types in trans #37110

Closed
wants to merge 1 commit into from
Closed

normalize tuple pair types in trans #37110

wants to merge 1 commit into from

Conversation

TimNN
Copy link
Contributor

@TimNN TimNN commented Oct 12, 2016

Fixes #37109.

Note that #37109 is a regression from stable to stable, beta and nightly.

@rust-highfive
Copy link
Collaborator

r? @Aatch

(rust_highfive has picked a reviewer for you, use r? to override)

@eddyb
Copy link
Member

eddyb commented Oct 12, 2016

@bors r+

@bors
Copy link
Contributor

bors commented Oct 12, 2016

📌 Commit 7badc32 has been approved by eddyb

@eddyb eddyb added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 12, 2016
@nikomatsakis nikomatsakis mentioned this pull request Oct 12, 2016
Closed
@alexcrichton alexcrichton mentioned this pull request Oct 12, 2016
Merged
@arielb1
Copy link
Contributor

arielb1 commented Oct 12, 2016

Why are we passing a non-normalized tuple around anyway?

@eddyb
Copy link
Member

eddyb commented Oct 12, 2016

Oh for some reason I thought this had soemthing to do with tuple structs, oops. Yeah that is interesting, makes this only a bandaid.

@arielb1
Copy link
Contributor

arielb1 commented Oct 12, 2016

I have a better fix.

@arielb1
Copy link
Contributor

arielb1 commented Oct 12, 2016

@bors r-

@TimNN TimNN closed this Oct 12, 2016
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Oct 12, 2016
@alexcrichton
Rollup merge of rust-lang#37110 - TimNN:fix-37109, r=eddyb
27043b1 
normalize tuple pair types in trans

Fixes rust-lang#37109.

Note that rust-lang#37109 is a regression from stable to stable, beta and nightly.
bors added a commit that referenced this pull request Oct 12, 2016
@bors
Auto merge of #37118 - alexcrichton:rollup, r=alexcrichton
d34318d 
Rollup of 17 pull requests

- Successful merges: #36762, #36831, #36973, #36991, #36995, #37023, #37049, #37050, #37056, #37064, #37066, #37067, #37084, #37089, #37091, #37092, #37110
- Failed merges:
@TimNN TimNN mentioned this pull request Oct 13, 2016
Merged
@brson
Copy link
Contributor

brson commented Oct 14, 2016

It's not clear that this should be backported to beta, or that #37129 should instead.

@brson brson removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 14, 2016
@TimNN TimNN deleted the fix-37109 branch April 7, 2017 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Aatch Aatch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@TimNN @rust-highfive @eddyb @bors @arielb1 @brson @Aatch