Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix importing inaccessible extern crates (with a warning) #37023

Merged
merged 2 commits into from
Oct 13, 2016
Merged

Fix importing inaccessible extern crates (with a warning) #37023

merged 2 commits into from
Oct 13, 2016

Conversation

jseyfried
Copy link
Contributor

@jseyfried jseyfried commented Oct 7, 2016 •
edited
Loading

#35776 broke importing inaccessible extern crates, which should work with a warning (c.f. #31362).

Fixes #36747, fixes #37020, and fixes #37021.
r? @nrc

This was referenced Oct 7, 2016
Closed
Closed
@nikomatsakis nikomatsakis added beta-nominated Nominated for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 7, 2016
@nikomatsakis
Copy link
Contributor

Nominating for backport because regression.

@TimNN TimNN mentioned this pull request Oct 7, 2016
Closed
@TimNN
Copy link
Contributor

TimNN commented Oct 7, 2016

Fixes #37018 as well.

@TimNN TimNN mentioned this pull request Oct 7, 2016
Closed
@TimNN
Copy link
Contributor

TimNN commented Oct 7, 2016

And also fixes #37021.

@alexcrichton
Copy link
Member

Thanks for the quick fixes @jseyfried!

@nrc
Copy link
Member

nrc commented Oct 11, 2016

@bors: r+

@bors
Copy link
Contributor

bors commented Oct 11, 2016

📌 Commit 4080efd has been approved by nrc

@nikomatsakis nikomatsakis added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Oct 11, 2016
@nikomatsakis
Copy link
Contributor

Marking as beta-accepted. Short patch, fixes regression.

cc @rust-lang/compiler

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Oct 11, 2016
Rollup merge of rust-lang#37023 - jseyfried:fix_extern_crate_back_com…
fa1140b 
…pat, r=nrc

Fix importing inaccessible `extern crate`s (with a warning)

Fixes rust-lang#36747, fixes rust-lang#37020, and fixes rust-lang#37021.
r? @nrc
@sophiajt sophiajt mentioned this pull request Oct 11, 2016
Closed
bors added a commit that referenced this pull request Oct 12, 2016
@bors
Auto merge of #37093 - jonathandturner:rollup, r=jonathandturner
ccb8b3e 
Rollup of 10 pull requests

- Successful merges: #36692, #36743, #36762, #36991, #37023, #37050, #37056, #37064, #37066, #37067
- Failed merges:
@alexcrichton alexcrichton mentioned this pull request Oct 12, 2016
Merged
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Oct 12, 2016
@alexcrichton
Rollup merge of rust-lang#37023 - jseyfried:fix_extern_crate_back_com…
65fc3ef 
…pat, r=nrc

Fix importing inaccessible `extern crate`s (with a warning)

Fixes rust-lang#36747, fixes rust-lang#37020, and fixes rust-lang#37021.
r? @nrc
bors added a commit that referenced this pull request Oct 12, 2016
@bors
Auto merge of #37118 - alexcrichton:rollup, r=alexcrichton
d34318d 
Rollup of 17 pull requests

- Successful merges: #36762, #36831, #36973, #36991, #36995, #37023, #37049, #37050, #37056, #37064, #37066, #37067, #37084, #37089, #37091, #37092, #37110
- Failed merges:
@bors bors merged commit 4080efd into rust-lang:master Oct 13, 2016
@jseyfried jseyfried deleted the fix_extern_crate_back_compat branch October 16, 2016 09:30
@brson brson mentioned this pull request Oct 19, 2016
Merged
@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nrc nrc

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
6 participants
@jseyfried @nikomatsakis @TimNN @alexcrichton @nrc @bors