-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add println!() macro with out any arguments #36825
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Thanks for the PR! This seems like a reasonable feature to me, especially given that we've got |
@sbwtw It looks like these two tests failed due to the changes:
You can find them inside |
@bluss @alexcrichton hi, I have modified the test code. |
What about letting |
@sinkuu seems good, but I think its better to modify it in another commit. |
Thanks @sbwtw! This is tagged with |
@rfcbot fcp merge Seems like a neat feature to me! |
FCP proposed with disposition to merge. Review requested from: No concerns currently listed. |
@bors: r+ |
📌 Commit 7d6227a has been approved by |
add println!() macro with out any arguments lets add println!() to write "\n". like java https://docs.oracle.com/javase/7/docs/api/java/io/PrintStream.html#println()
All relevant subteam members have reviewed. No concerns remain. |
It has been one week since all blocks to the FCP were resolved. |
Allow `writeln!` without arguments, in symmetry with `println!` CC #36825.
lets add println!() to write "\n".
like java https://docs.oracle.com/javase/7/docs/api/java/io/PrintStream.html#println()