Correct span for pub_restricted field #35491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -18,6 +20,11 @@ struct Foo { | |||
| //~^ error: field `bar` is already declared [E0124] | |||
| bar: u8, | |||
|
|
|||
| pub | |||
There was a problem hiding this comment.
May I suggest you use a ui test? That way you can actually directly record the highlight that is expected, giving more precision.
sanxiyn
force-pushed
the
pub-restricted-span
branch
from
a6b40be
to
f76a737
Compare
|
Changed test to ui test. |
|
@bors r+ |
|
📌 Commit f76a737 has been approved by |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Aug 13, 2016
…matsakis Correct span for pub_restricted field Fix rust-lang#35435.
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Aug 13, 2016
…matsakis Correct span for pub_restricted field Fix rust-lang#35435.
|
@bors rollup |
eddyb
added a commit
to eddyb/rust
that referenced
this pull request
Aug 14, 2016
…matsakis Correct span for pub_restricted field Fix rust-lang#35435.
eddyb
added a commit
to eddyb/rust
that referenced
this pull request
Aug 14, 2016
…matsakis Correct span for pub_restricted field Fix rust-lang#35435.
bors
added a commit
that referenced
this pull request
Aug 14, 2016
Rollup of 30 pull requests - Successful merges: #34941, #35392, #35444, #35447, #35491, #35533, #35539, #35558, #35573, #35574, #35577, #35586, #35588, #35594, #35596, #35597, #35598, #35606, #35611, #35615, #35616, #35620, #35622, #35640, #35643, #35644, #35646, #35647, #35648, #35661 - Failed merges: #35395, #35415
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #35435.