-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update E0229 to new format #35374
Update E0229 to new format #35374
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Thanks for the PR! Yeah, it's suspicious when none of the unit tests catch that you made the change. I talk about this a bit on my blog post Even though there aren't any failures, you should update the unit test with the new label so it can be tested. You just need to add a You can also do a |
Looks good! @bors r+ rollup |
📌 Commit 51a270f has been approved by |
…urner Update E0229 to new format Hello, This fixes rust-lang#35305. I ran the tests, no unit test broke, even though some were ignored. Cheers r? @jonathandturner
…urner Update E0229 to new format Hello, This fixes rust-lang#35305. I ran the tests, no unit test broke, even though some were ignored. Cheers r? @jonathandturner
Hello,
This fixes #35305, for #35233. I ran the tests, no unit test broke, even though some were ignored.
Cheers
r? @jonathandturner