Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix non-termination on recursive module re-exports in extern crates #34542

Merged
merged 2 commits into from
Jun 30, 2016
Merged

Fix non-termination on recursive module re-exports in extern crates #34542

merged 2 commits into from
Jun 30, 2016

Conversation

jseyfried
Copy link
Contributor

Fixes #33776.
r? @nrc

@jseyfried jseyfried mentioned this pull request Jun 29, 2016
Closed
@nrc
Copy link
Member

nrc commented Jun 29, 2016

The performance implications here make me a bit nervous (but maybe I am paranoid), this adds a loop over the work list for every iteration of a loop which itself is in a lookup function. Is the size of the work list known to be 'small'? Or have you tried measuring the performance impact of this change?

@jseyfried
Copy link
Contributor Author

jseyfried commented Jun 29, 2016 •
edited
Loading

@nrc That function is only called on type or trait name resolution errors (c.f. #31674).

@nrc
Copy link
Member

nrc commented Jun 29, 2016

@bors: r+

@bors
Copy link
Contributor

bors commented Jun 29, 2016

📌 Commit 9ffe1c9 has been approved by nrc

Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 29, 2016
@Manishearth
Rollup merge of rust-lang#34542 - jseyfried:fix_recursive_modules, r=nrc
8e2598c 
Fix non-termination on recursive module re-exports in extern crates

Fixes rust-lang#33776.
r? @nrc
@Manishearth Manishearth mentioned this pull request Jun 29, 2016
Merged
bors added a commit that referenced this pull request Jun 30, 2016
@bors
Auto merge of #34552 - Manishearth:rollup, r=Manishearth
c2b56fb 
Rollup of 11 pull requests

- Successful merges: #34355, #34446, #34459, #34460, #34467, #34495, #34497, #34499, #34513, #34536, #34542
- Failed merges:
@bors bors merged commit 9ffe1c9 into rust-lang:master Jun 30, 2016
@jseyfried jseyfried deleted the fix_recursive_modules branch December 22, 2016 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nrc nrc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jseyfried @nrc @bors