Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend+improve HIR types documentation #34521

Merged
merged 2 commits into from
Jul 7, 2016
Merged

Conversation

llogiq
Copy link
Contributor

@llogiq llogiq commented Jun 28, 2016

No description provided.

@rust-highfive
Copy link
Collaborator

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@llogiq
Copy link
Contributor Author

llogiq commented Jun 28, 2016

r? @steveklabnik

@rust-highfive rust-highfive assigned steveklabnik and unassigned eddyb Jun 28, 2016
@@ -919,13 +919,13 @@ pub enum Expr_ {
/// Inline assembly (from `asm!`), with its outputs and inputs.
ExprInlineAsm(InlineAsm, Vec<P<Expr>>, Vec<P<Expr>>),

/// A struct literal expression.
/// A struct or enum variant literal expression.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "struct-like variant" is the correct term here.

@llogiq
Copy link
Contributor Author

llogiq commented Jun 28, 2016

@eddyb thank you, done.

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Jul 5, 2016

📌 Commit 5de684a has been approved by steveklabnik

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jul 5, 2016
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jul 5, 2016
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jul 6, 2016
bors added a commit that referenced this pull request Jul 7, 2016
@bors bors merged commit 5de684a into rust-lang:master Jul 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants