Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve err expl #33914

Merged
merged 4 commits into from
May 30, 2016
Merged

Improve err expl #33914

merged 4 commits into from
May 30, 2016

Conversation

GuillaumeGomez
Copy link
Member

steveklabnik
steveklabnik reviewed May 27, 2016
View reviewed changes
src/librustc/diagnostics.rs
point into a Rust program.
point into a Rust program. Example:


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's two spaces here, should be just one

@GuillaumeGomez
Copy link
Member Author

Updated.

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented May 28, 2016

📌 Commit 5212a18 has been approved by steveklabnik

@bors
Copy link
Contributor

bors commented May 29, 2016

⌛ Testing commit 5212a18 with merge f1479cb...

@bors
Copy link
Contributor

bors commented May 29, 2016

💔 Test failed - auto-linux-64-opt-rustbuild

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented May 29, 2016 •
edited
Loading

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented May 29, 2016

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
  • There's another pull request that is currently being tested, blocking this pull request: save-temps was moved under the -C switch #33902

@bors
Copy link
Contributor

bors commented May 29, 2016

📌 Commit 5212a18 has been approved by GuillaumeGomez

@GuillaumeGomez
Copy link
Member Author

@bors: retry

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request May 29, 2016
@GuillaumeGomez
Rollup merge of rust-lang#33914 - GuillaumeGomez:improve_err_expl, r=…
1d8ff57 
…GuillaumeGomez

Improve err expl

r? @steveklabnik
@GuillaumeGomez GuillaumeGomez mentioned this pull request May 29, 2016
Closed
bors added a commit that referenced this pull request May 29, 2016
@bors
Auto merge of #33948 - GuillaumeGomez:rollup, r=GuillaumeGomez
1d78a61 
Rollup of 10 pull requests

- Successful merges: #33793, #33893, #33902, #33912, #33913, #33914, #33917, #33931, #33937, #33938
- Failed merges:
@GuillaumeGomez
Copy link
Member Author

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 29, 2016

📌 Commit 31b9060 has been approved by GuillaumeGomez

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request May 29, 2016
@GuillaumeGomez
Rollup merge of rust-lang#33914 - GuillaumeGomez:improve_err_expl, r=…
deb6bc6 
…GuillaumeGomez

Improve err expl

r? @steveklabnik
@bors
Copy link
Contributor

bors commented May 30, 2016

⌛ Testing commit 31b9060 with merge dd5a1da...

@bors
Copy link
Contributor

bors commented May 30, 2016

💔 Test failed - auto-linux-64-cross-netbsd

@GuillaumeGomez
Copy link
Member Author

@bors: retry

Manishearth added a commit to Manishearth/rust that referenced this pull request May 30, 2016
@Manishearth
Rollup merge of rust-lang#33914 - GuillaumeGomez:improve_err_expl, r=…
c41e9d9 
…GuillaumeGomez

Improve err expl

r? @steveklabnik
@Manishearth Manishearth mentioned this pull request May 30, 2016
Merged
bors added a commit that referenced this pull request May 30, 2016
@bors
Auto merge of #33959 - Manishearth:rollup, r=Manishearth
5da602b 
Rollup of 8 pull requests

- Successful merges: #33793, #33893, #33912, #33913, #33914, #33917, #33937, #33938
- Failed merges:
@bors bors merged commit 31b9060 into rust-lang:master May 30, 2016
@GuillaumeGomez GuillaumeGomez deleted the improve_err_expl branch May 30, 2016 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@steveklabnik steveklabnik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GuillaumeGomez @steveklabnik @bors