-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix macro expansion backtrace diagnostics #33730
Fix macro expansion backtrace diagnostics #33730
Conversation
For example, consider: macro_rules! m {
() => { { error } }
}
fn main() { m!(); } Currently, the diagnostics are:
After this PR, the diagnostics will be the same as on beta:
|
@jseyfried can we add a test for this? |
@nikomatsakis I don't know -- I'm not very familiar with the recent changes to the testing framework. |
@bors r+ rollup |
📌 Commit f8e9c15 has been approved by |
we could make a ui test, but maybe not worth it -- @jonathandturner and I did plan to revisit how macro backtraces are presented, maybe we'll do it then |
…ostics, r=nikomatsakis Fix macro expansion backtrace diagnostics Fixes rust-lang#33704. r? @nikomatsakis
Fixes #33704.
r? @nikomatsakis