Implement RFC 1542 #33426
Merged
Implement RFC 1542 #33426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| not be exposed publicly", | ||
| issue = "0")] | ||
| #[doc(hidden)] | ||
| pub fn __description(&self) -> &str { |
There was a problem hiding this comment.
Yuck! But I guess such is life for private sharing across the facade...
There was a problem hiding this comment.
Yeah, this is what the existing ParseIntError did :(
|
Basically LGTM, but I'd like tests for the edge cases on the numeric conversions. |
|
Yep, will add tests tonight |
|
Thanks for doing this @sfackler, I'm quite excited for these traits. :-) |
|
Added some tests @bors r=aturon |
|
📌 Commit a9779df has been approved by |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
May 8, 2016
Implement RFC 1542 cc rust-lang#33417 r? @aturon
bors
added a commit
that referenced
this pull request
May 8, 2016
|
☔ The latest upstream changes (presumably #33091) made this pull request unmergeable. Please resolve the merge conflicts. |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
May 8, 2016
Implement RFC 1542 cc rust-lang#33417 r? @aturon
bors
added a commit
that referenced
this pull request
May 8, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #33417
r? @aturon