-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove negate_unsigned feature gate #30538
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
eb77d1d
to
03b6056
Compare
Thanks! Could you also squash the commits down into one? |
This will break nightly programs that use the |
03b6056
to
9f44261
Compare
squashed, added |
b096737
to
9e215c7
Compare
I think the help message should mention |
@ollie27 I am not sure if |
The Travis failures look legitimate |
9e215c7
to
cb0858b
Compare
fixed tidy errors and adjusted the second test's help messages |
(Statement retracted, nuke it from orbit) |
@bors rollup |
⌛ Testing commit cb0858b with merge 38683b9... |
💔 Test failed - auto-linux-64-nopt-t |
…n, r=pnkfelix fixes rust-lang#29645
…n, r=pnkfelix fixes rust-lang#29645
@bors: r- this failed the rollup |
@oli-obk looks like it needs to be updated to use the new structured error API for the |
cb0858b
to
bac3eec
Compare
rebased and fixed |
@bors r+ bac3eec rollup |
…n, r=pnkfelix fixes rust-lang#29645
fixes #29645