Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove negate_unsigned feature gate #30538

Merged
merged 1 commit into from
Jan 12, 2016

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Dec 23, 2015

fixes #29645

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

Thanks! Could you also squash the commits down into one?

@hanna-kruppe
Copy link
Contributor

This will break nightly programs that use the negate_unsigned feature, right? If so, please throw a [breaking-change] in the PR description or in one of the commit messages.

@oli-obk
Copy link
Contributor Author

oli-obk commented Dec 27, 2015

squashed, added [breaking-change] and rewrote the help message

@oli-obk oli-obk force-pushed the kill_unsigned_unary_negation branch 2 times, most recently from b096737 to 9e215c7 Compare December 27, 2015 12:56
@ollie27
Copy link
Member

ollie27 commented Dec 27, 2015

I think the help message should mention .wrapping_neg() because it matches the behaviour of the current unsigned negation and can't overflow.

@pnkfelix
Copy link
Member

@ollie27 I am not sure if wrapping_neg is a const fn, so such a message could be misleading in a const expression context. .. still there might be a way to phrase the suggestion (or only emit it in non const contexts? )

@pnkfelix
Copy link
Member

The Travis failures look legitimate

@oli-obk
Copy link
Contributor Author

oli-obk commented Dec 27, 2015

fixed tidy errors and adjusted the second test's help messages

@emberian
Copy link
Member

(Statement retracted, nuke it from orbit)

@pnkfelix
Copy link
Member

@bors r+ cb0858b

@pnkfelix
Copy link
Member

@bors rollup

@bors
Copy link
Contributor

bors commented Dec 31, 2015

⌛ Testing commit cb0858b with merge 38683b9...

@bors
Copy link
Contributor

bors commented Dec 31, 2015

💔 Test failed - auto-linux-64-nopt-t

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jan 5, 2016
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Jan 5, 2016
@steveklabnik
Copy link
Member

@bors: r-

this failed the rollup

@pnkfelix
Copy link
Member

pnkfelix commented Jan 6, 2016

@oli-obk looks like it needs to be updated to use the new structured error API for the span_note call?

@oli-obk oli-obk force-pushed the kill_unsigned_unary_negation branch from cb0858b to bac3eec Compare January 11, 2016 11:32
@oli-obk
Copy link
Contributor Author

oli-obk commented Jan 11, 2016

rebased and fixed

@pnkfelix
Copy link
Member

@bors r+ bac3eec rollup

nagisa added a commit to nagisa/rust that referenced this pull request Jan 11, 2016
bors added a commit that referenced this pull request Jan 11, 2016
@bors bors merged commit bac3eec into rust-lang:master Jan 12, 2016
@oli-obk oli-obk deleted the kill_unsigned_unary_negation branch January 13, 2016 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking issue for negate_unsigned feature
9 participants