Rollup of 6 pull requests #30410
Merged
Rollup of 6 pull requests #30410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Manishearth
commented
Dec 16, 2015
Manishearth
commented
- Successful merges: Make name resolution errors non-fatal #30320, fix dropck performance regression #30368, Use --cfg when running doctests #30372, Add links in BTreeSet docs #30376, Generated code spans now point to callsite parameters (where applicable) #30388, Stop re-exporting RestrictionResult variants. #30392
- Failed merges: rustc: Remove def::DefUse #30354, Make RFC 1214 warnings into errors #30389
Turns out that calling `resolve_type_variables_if_possible` in a O(n^2) loop is a bad idea. Now we just resolve each copy of the region variable to its lowest name each time (we resolve the region variable to its lowest name, rather than to its unify-table name to avoid the risk of the unify-table name changing infinitely many times. That may be not a problem in practice, but I am not sure of it).
Previously passed --cfg was used only when collecting doctests.
We can now handle name resolution errors and get past type checking (if we're a bit lucky). This is the first step towards doing code completion for partial programs (we need error recovery in the parser and early access to save-analysis).
…omatsakis Turns out that calling `resolve_type_variables_if_possible` in a O(n^2) loop is a bad idea. Now we just resolve each copy of the region variable to its lowest name each time (we resolve the region variable to its lowest name, rather than to its unify-table name to avoid the risk of the unify-table name changing infinitely many times. That may be not a problem in practice, but I am not sure of it).
…hton The BtreeSet main description mentions `BTreeMap`, `Ord`, `Cell`, `RefCell`. This patch adds links to their documentation.
|
r? @arielb1 (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ p=20 force |
|
📌 Commit f0361a0 has been approved by |
bors
added a commit
that referenced
this pull request
Dec 16, 2015
This was referenced Dec 16, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.