Make the Metadata struct Clone #29021
Conversation
This commit adds #[derive(Clone)] to std::fs::Metadata, making that struct cloneable. Although the exact contents of that struct differ between OSes, they all have it contain only value types, meaning that the data can be re-used without repercussions. It also adds #[derive(Clone)] to every type used by that struct across all OSes, including the various Unix `stat` structs and Windows's `WIN32_FILE_ATTRIBUTE_DATA`.
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Thanks! I'd like to circulate this a little bit first just to make sure there's no gotchas here, but other than that this looks good to me! |
alexcrichton
added
the
T-libs-api
|
Just a note that impls are "insta-stable" -- do we maybe want to have this be something that is only conditionally derived? |
|
LGTM. |
brson
added
the
relnotes
This commit adds `#[derive(Clone)]` to `std::fs::Metadata`, making that struct cloneable. Although the exact contents of that struct differ between OSes, they all have it contain only value types, meaning that the data can be re-used without repercussions. It also adds `#[derive(Clone)]` to every type used by that struct across all OSes, including the various Unix `stat` structs and Windows's `WIN32_FILE_ATTRIBUTE_DATA`. This stems from my comment here: rust-lang/rfcs#939 (comment)
This commit adds
#[derive(Clone)]tostd::fs::Metadata, making that struct cloneable. Although the exact contents of that struct differ between OSes, they all have it contain only value types, meaning that the data can be re-used without repercussions.It also adds
#[derive(Clone)]to every type used by that struct across all OSes, including the various Unixstatstructs and Windows'sWIN32_FILE_ATTRIBUTE_DATA.This stems from my comment here: rust-lang/rfcs#939 (comment)