Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rt::default_sched_threads and RUST_THREADS. #23534

Closed

Conversation

steveklabnik
Copy link
Member

As @alexcrichton says, this was really a libgreen thing, and isn't
relevant now.

As this removes a technically-public function, this is a

[breaking-change]

@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@aturon
Copy link
Member

aturon commented Mar 19, 2015

@bors: r+ c6a24e4

@alexcrichton
Copy link
Member

/me sheds a single tear

@steveklabnik
Copy link
Member Author

ALEX_NUM_TEARS=1

@Manishearth
Copy link
Member

Note: this has a merge conflict with #23535, so it might not make it into the rollup (though it's in the rollup for now).

@pnkfelix
Copy link
Member

@Manishearth did you mean to write #23525 up above?

@Manishearth
Copy link
Member

Yep, sorry

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 20, 2015
…r=alexcrichton

As @alexcrichton says, this was really a libgreen thing, and isn't
relevant now.

As this removes a technically-public function, this is a

[breaking-change]
@bors
Copy link
Contributor

bors commented Mar 20, 2015

🔒 Merge conflict

@bors
Copy link
Contributor

bors commented Mar 20, 2015

☔ The latest upstream changes (presumably #23548) made this pull request unmergeable. Please resolve the merge conflicts.

@Manishearth
Copy link
Member

This merged as 6107e4c

(needed fixing of conflicts)

This PR can be closed.

As @alexcrichton says, this was really a libgreen thing, and isn't
relevant now.

As this removes a technically-public function, this is a

[breaking-change]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants