Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More library DSTification #19050

Merged
merged 3 commits into from
Nov 18, 2014
Merged

More library DSTification #19050

merged 3 commits into from
Nov 18, 2014

Conversation

japaric
Copy link
Member

@japaric japaric commented Nov 17, 2014

r? @aturon
cc #16918

@japaric
Copy link
Member Author

japaric commented Nov 17, 2014

There's still more, but I have tested up to this point. I'll post an updated table in #16918.

fn llrepr(&self, ccx: &CrateContext) -> String;
}

impl<'a, T:LlvmRepr> LlvmRepr for &'a [T] {
impl<'a, T:LlvmRepr> LlvmRepr for [T] {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stray 'a here.

@aturon
Copy link
Member

aturon commented Nov 17, 2014

Looks good, r=me modulo tiny nit.

@japaric
Copy link
Member Author

japaric commented Nov 17, 2014

Removed stray 'a (I really want rust-lang/rfcs#447 to be implemented!)

@aturon re-r?

bors added a commit that referenced this pull request Nov 18, 2014
@bors bors closed this Nov 18, 2014
@bors bors merged commit d50e80f into rust-lang:master Nov 18, 2014
@japaric japaric deleted the moar-dst branch December 16, 2014 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants