Add core::arch::breakpoint and test
#133726
Merged
+66
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshtriplett
added
the
T-libs-api
|
r? @Noratrieb rustbot has assigned @Noratrieb. Use |
rustbot
added
S-waiting-on-review
|
Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter cc @rust-lang/miri, @rust-lang/wg-const-eval |
joshtriplett
removed
the
T-compiler
This comment has been minimized.
This comment has been minimized.
4 tasks
joshtriplett
force-pushed
the
breakpoint
branch
from
f6b34bd to
70de878
Compare
This comment has been minimized.
This comment has been minimized.
oli-obk
reviewed
Dec 2, 2024
joshtriplett
force-pushed
the
breakpoint
branch
2 times, most recently
from
4959ea0 to
5f8cc9a
Compare
This comment has been minimized.
This comment has been minimized.
joshtriplett
force-pushed
the
breakpoint
branch
from
5f8cc9a to
1fc2831
Compare
This comment has been minimized.
This comment has been minimized.
joshtriplett
force-pushed
the
breakpoint
branch
from
1fc2831 to
6d14285
Compare
This comment has been minimized.
This comment has been minimized.
joshtriplett
force-pushed
the
breakpoint
branch
from
6d14285 to
2018889
Compare
This comment has been minimized.
This comment has been minimized.
joshtriplett
force-pushed
the
breakpoint
branch
from
2018889 to
7c2bf39
Compare
This comment has been minimized.
This comment has been minimized.
joshtriplett
force-pushed
the
breakpoint
branch
from
7c2bf39 to
1be35f1
Compare
This comment has been minimized.
This comment has been minimized.
joshtriplett
force-pushed
the
breakpoint
branch
from
1be35f1 to
87fb6ca
Compare
This comment has been minimized.
This comment has been minimized.
|
The Miri subtree was changed cc @rust-lang/miri |
This comment has been minimized.
This comment has been minimized.
joshtriplett
force-pushed
the
breakpoint
branch
from
f043ae7 to
afca178
Compare
This comment has been minimized.
This comment has been minimized.
RalfJung
reviewed
Dec 3, 2024
joshtriplett
force-pushed
the
breakpoint
branch
from
afca178 to
a5c107b
Compare
RalfJung
reviewed
Dec 3, 2024
This comment has been minimized.
This comment has been minimized.
Approved in [ACP 491](rust-lang/libs-team#491). Remove the `unsafe` on `core::intrinsics::breakpoint()`, since it's a safe intrinsic to call and has no prerequisites. (Thanks to @zachs18 for figuring out the `bootstrap`/`not(bootstrap)` logic.)
joshtriplett
force-pushed
the
breakpoint
branch
from
a5c107b to
cea0582
Compare
|
r? @oli-obk |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 3, 2024
Add `core::arch::breakpoint` and test Approved in [ACP 491](rust-lang/libs-team#491).
bjorn3
reviewed
Dec 3, 2024
| /// normal execution with no debug tooling involved this will not continue executing. | ||
| /// | ||
| /// - On x86 targets, this produces an `int3` instruction. | ||
| /// - On aarch64 targets, this produces a `brk #0xf000` instruction. |
There was a problem hiding this comment.
Cranelift emits brk #0. Should this be changed on the Cranelift side?
There was a problem hiding this comment.
@bjorn3 Yes, I think so. Some debuggers on aarch64 recognize brk #0xf000 as a hint to skip past that instruction when resuming.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 4, 2024
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#132937 (a release operation synchronizes with an acquire operation) - rust-lang#133681 (improve TagEncoding::Niche docs, sanity check, and UB checks) - rust-lang#133726 (Add `core::arch::breakpoint` and test) - rust-lang#133768 (Remove `generic_associated_types_extended` feature gate) - rust-lang#133811 ([AIX] change AIX default codemodel=large) - rust-lang#133812 (Update wasm-component-ld to 0.5.11) - rust-lang#133813 (compiletest: explain that UI tests are expected not to compile by default) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 4, 2024
Rollup merge of rust-lang#133726 - joshtriplett:breakpoint, r=oli-obk Add `core::arch::breakpoint` and test Approved in [ACP 491](rust-lang/libs-team#491).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Approved in ACP 491.