Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc-search: case-sensitive only when capitals are used #133043

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

notriddle
Copy link
Contributor

This is the "smartcase" behavior, described by vim and dtolnay.

Fixes #133017

This is the "smartcase" behavior, described by vim and dtolnay.
@rustbot
Copy link
Collaborator

rustbot commented Nov 14, 2024

r? @fmease

rustbot has assigned @fmease.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Nov 14, 2024
@rustbot
Copy link
Collaborator

rustbot commented Nov 14, 2024

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @jsha

@fmease
Copy link
Member

fmease commented Nov 14, 2024

r=me once green

@fmease fmease added beta-nominated Nominated for backporting to the compiler in the beta channel. stable-nominated Nominated for backporting to the compiler in the stable channel. labels Nov 14, 2024
@fmease
Copy link
Member

fmease commented Nov 14, 2024

Nominating for beta & stable backport. As per usual, the stable nomination isn't meant to force a point release but is to be understood as 'reserving a seat' in case there happens to be a point release at T-release's discretion.

@fmease
Copy link
Member

fmease commented Nov 14, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Nov 14, 2024

📌 Commit 32500aa has been approved by fmease

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 14, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 14, 2024
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#128197 (Skip locking span interner for some syntax context checks)
 - rust-lang#133040 ([rustdoc] Fix handling of footnote reference in footnote definition)
 - rust-lang#133043 (rustdoc-search: case-sensitive only when capitals are used)
 - rust-lang#133046 (Clippy subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8912909 into rust-lang:master Nov 15, 2024
6 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Nov 15, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 15, 2024
Rollup merge of rust-lang#133043 - notriddle:master, r=fmease

rustdoc-search: case-sensitive only when capitals are used

This is the "smartcase" behavior, described by vim and dtolnay.

Fixes rust-lang#133017
@fmease
Copy link
Member

fmease commented Nov 15, 2024

Beta backport accepted as per Zulip poll.
@rustbot label beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Nov 15, 2024
@cuviper cuviper mentioned this pull request Nov 15, 2024
@cuviper cuviper modified the milestones: 1.84.0, 1.83.0 Nov 15, 2024
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Nov 15, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 15, 2024
[beta] backports

- Use completion item indices instead of property matching rust-lang#132987, rust-lang/rust-analyzer#18503
- Reject raw lifetime followed by `'`, like regular lifetimes do rust-lang#132341
- Only disable cache if predicate has opaques within it rust-lang#132625
- rustdoc-search: case-sensitive only when capitals are used rust-lang#133043

r? cuviper
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 16, 2024
[beta] backports

- Use completion item indices instead of property matching rust-lang#132987, rust-lang/rust-analyzer#18503
- Reject raw lifetime followed by `'`, like regular lifetimes do rust-lang#132341
- Only disable cache if predicate has opaques within it rust-lang#132625
- rustdoc-search: case-sensitive only when capitals are used rust-lang#133043
- (ci) Update macOS Xcode to 15 rust-lang#131570

r? cuviper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. stable-nominated Nominated for backporting to the compiler in the stable channel. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rustdoc search ranking regression in 1.82
5 participants