-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert #132772 to fix unknown git commit hash #132846
Conversation
This PR modifies If appropriate, please update This PR modifies If appropriate, please update |
@bors r+ p=10 |
Since queue is very light, I'm going to yield the other PR that just started. @bors rollup=never |
Revert rust-lang#132772 to fix unknown git commit hash Reverts rust-lang#132772 to address rust-lang#132845, we seem to have unintentionally omitted commit hash. r? `@onur-ozkan`
(I was going to self-approve as per revert policy but was double-checking queue, this works too 😆) |
This comment has been minimized.
This comment has been minimized.
Huh. This failed well because commit hash was |
💔 Test failed - checks-actions |
…default, r=jieyouxu" This reverts commit c435fa8, reversing changes made to 88acd49. Seems to have unintentionally omitted commit hash leading to <rust-lang#132772>.
5dbf135
to
c4c6d2b
Compare
@bors r+ |
🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened. |
@bors p=1001 |
PR to re-enable |
The 2nd commit here can be reverted once #132852 landed. |
☀️ Test successful - checks-actions |
@bors treeclosed- |
Finished benchmarking commit (c22887b): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary 2.0%, secondary -3.1%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeResults (primary 0.1%, secondary 0.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 787.727s -> 787.115s (-0.08%) |
Revert rust-lang#132772 to fix unknown git commit hash Reverts rust-lang#132772 to address rust-lang#132845, we seem to have unintentionally omitted commit hash. r? `@onur-ozkan`
Reverts #132772 to address #132845, we seem to have unintentionally omitted commit hash.
r? @onur-ozkan