abi/compatibility: also test Option-like types #132002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @davidtwco rustbot has assigned @davidtwco. Use |
rustbot
added
S-waiting-on-review
RalfJung
force-pushed
the
abi-compat-option-like
branch
from
d6c85a0
to
b31b595
Compare
Noratrieb
reviewed
Oct 21, 2024
RalfJung
force-pushed
the
abi-compat-option-like
branch
from
b31b595
to
d567fcc
Compare
workingjubilee
added
the
A-ABI
compiler-errors
approved these changes
Oct 22, 2024
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 22, 2024
…=compiler-errors abi/compatibility: also test Option-like types Adds tests for the decision [here](rust-lang#130628 (comment)). Cc `@workingjubilee`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 22, 2024
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#132002 (abi/compatibility: also test Option-like types) - rust-lang#132026 (analyse: remove unused uncanonicalized field) - rust-lang#132036 (Add a test case for rust-lang#131164) - rust-lang#132040 (relnotes: fix stabilizations of `assume_init`) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 23, 2024
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#131707 (Run most `core::num` tests in const context too) - rust-lang#132002 (abi/compatibility: also test Option-like types) - rust-lang#132026 (analyse: remove unused uncanonicalized field) - rust-lang#132031 (Optimize `Rc<T>::default`) - rust-lang#132040 (relnotes: fix stabilizations of `assume_init`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 23, 2024
Rollup merge of rust-lang#132002 - RalfJung:abi-compat-option-like, r=compiler-errors abi/compatibility: also test Option-like types Adds tests for the decision [here](rust-lang#130628 (comment)). Cc ``@workingjubilee``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests for the decision here.
Cc @workingjubilee