Fix missing rustfmt in msi installer #101993

[heiseish]

Context

• Fixed missing rustfmt, clippy, miri and rust-analyzer in msi installer
• Fixed missing rustfmt for apple darwin installer
• Closes MSI installer is missing clippy and rustfmt #101993

r​? @jyn514

• Please let me know if I should request from someone else instead. I divided the changes into 3 separate commits for the ease of review. The refactoring commit fbdfd5c03c3c979bcf105ccdd05ff4ab9f37a763 is a bit more involved, but I think it helps in the long term for readability and to avoid bugs.
• I changed build-manifest to build_manifest in order to invoke it as a library. Not sure if this is gonna break any upstream processes. I checked generate-manifest-list and generate-release but didn't find any obvious reference
• Will push fixes for linting later

[rustbot]

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[rustbot]

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

[Mark-Simulacrum]

r=me on the first two commits with direct fixes. The refactoring commit is rather large and I'd prefer to see it split into a separate PR and/or have some discussion on Zulip first -- I'm not really following how reusing PkgType significantly helps avoid problems... it seems like a small part of the puzzle at best.

[heiseish]

@Mark-Simulacrum thanks! one of the benefits for the refactor commit is to keep the tool attributes (eg is_preview) consistent without having them duplicated in multiple places.

That said, I agree the refactor commit is a bit more involved and happy to open another PR for it. I could also revert the change to build-manifest and declare another enum for internal usage within build step.

[rustbot]

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git pull --rebase https://github.com/rust-lang/rust.git master
$ git push --force-with-lease

The following commits are merge commits:

• d42d9f3

[Mark-Simulacrum]

@bors r+

[bors]

📌 Commit 2316749 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

[Mark-Simulacrum]

I could also revert the change to build-manifest and declare another enum for internal usage within build step.

Maybe? I think de-duplicating constants probably makes sense, but my recollection (maybe incorrect) was that the refactoring did more than that. In any case, happy to see a separate PR and/or some Zulip discussion of the particulars.