Rollup of 4 pull requests #131354
Merged
Rollup of 4 pull requests #131354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's simpler and more concise.
It's slightly simpler.
These are only valid for coverage test modes.
Revert "warn_old_master_branch" check See rust-lang#131296 (comment). Reverts rust-lang#130121 and rust-lang#129584. Fixes rust-lang#131296 and rust-lang#131324.
…rors Avoid `&Lrc<T>` in various places Seeing `&Lrc<T>` is a bit suspicious, and `&T` or `Lrc<T>` is often better. r? `@oli-obk`
… r=Zalathar Restrict `ignore-mode-*` directives This is only used by coverage test suites where the same sources get run under different coverage modes. Restrict `ignore-mode-<coverage_mode>` to only coverage modes.
…option, r=jieyouxu Add documentation for `runtest::check_rustdoc_test_option` method r? `@jieyouxu`
rustbot
added
A-testsuite
|
@bors r+ rollup=never p=4 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: 0b16baa570 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (7caad69): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (secondary 2.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 774.407s -> 774.662s (0.03%) |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Oct 18, 2024
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#131331 (Revert "warn_old_master_branch" check) - rust-lang#131344 (Avoid `&Lrc<T>` in various places) - rust-lang#131346 (Restrict `ignore-mode-*` directives) - rust-lang#131353 (Add documentation for `runtest::check_rustdoc_test_option` method) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
&Lrc<T>in various places #131344 (Avoid&Lrc<T>in various places)ignore-mode-*directives #131346 (Restrictignore-mode-*directives)runtest::check_rustdoc_test_optionmethod #131353 (Add documentation forruntest::check_rustdoc_test_optionmethod)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup