-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 5 pull requests #130876
Rollup of 5 pull requests #130876
Commits on Sep 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 986e20d - Browse repository at this point
Copy the full SHA 986e20dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f1ed9b - Browse repository at this point
Copy the full SHA 8f1ed9bView commit details -
Fix directives for lint-non-snake-case-crate
This test fails on targets without unwinding because the proc macro was compiled as the target, not the host. Some targets were explicitly disabled to pass CI, but these directives are more general. Fixes Fuchsia tests.
Configuration menu - View commit details
-
Copy full SHA for c5925ef - Browse repository at this point
Copy the full SHA c5925efView commit details
Commits on Sep 26, 2024
-
Fix the misleading diagnostic for let_underscore_drop on type without…
… Drop implementation
Configuration menu - View commit details
-
Copy full SHA for 5892187 - Browse repository at this point
Copy the full SHA 5892187View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1bef68c - Browse repository at this point
Copy the full SHA 1bef68cView commit details -
Rollup merge of rust-lang#130820 - 91khr:fix-coroutine-unit-arg, r=co…
…mpiler-errors Fix diagnostics for coroutines with () as input. This may be a more real-life example to trigger the diagnostic: ```rust #![features(try_blocks, coroutine_trait, coroutines)] use std::ops::Coroutine; struct Request; struct Response; fn get_args() -> Result<String, String> { todo!() } fn build_request(_arg: String) -> Request { todo!() } fn work() -> impl Coroutine<Option<Response>, Yield = Request> { #[coroutine] |_| { let r: Result<(), String> = try { let req = get_args()?; yield build_request(req) }; if let Err(msg) = r { eprintln!("Error: {msg}"); } } } ```
Configuration menu - View commit details
-
Copy full SHA for 2dd2795 - Browse repository at this point
Copy the full SHA 2dd2795View commit details -
Rollup merge of rust-lang#130833 - makai410:master, r=compiler-errors…
…,fee1-dead Fix the misleading diagnostic for `let_underscore_drop` on type without `Drop` implementation Closes: rust-lang#130430 r? rust-lang/diagnostics
Configuration menu - View commit details
-
Copy full SHA for cc6d328 - Browse repository at this point
Copy the full SHA cc6d328View commit details -
Rollup merge of rust-lang#130845 - RalfJung:utf8chunk, r=tgross35
Utf8Chunks: add link to Utf8Chunk It is currently surprisingly non-trivial to go from the `utf8_chunks` method to the docs of the `valid`/`invalid` methods used in the example. This should help.
Configuration menu - View commit details
-
Copy full SHA for f9dbe10 - Browse repository at this point
Copy the full SHA f9dbe10View commit details -
Rollup merge of rust-lang#130860 - tmandry:fix-directives, r=compiler…
…-errors Fix directives for lint-non-snake-case-crate This test fails on targets without unwinding or with `--target-rustcflags=-Cpanic=abort` because the proc macro was compiled as the target, not the host. Some targets were explicitly disabled to pass CI, but these directives are more general. * `needs-dynamic-linking` is self explanatory * `force-host` for proc macros * `no-prefer-dynamic` is apparently also used for proc macros Note that `needs-unwind` can also be useful for situations other than proc macros where unwinding is necessary. r? ``@jieyouxu``
Configuration menu - View commit details
-
Copy full SHA for ba631b1 - Browse repository at this point
Copy the full SHA ba631b1View commit details -
Rollup merge of rust-lang#130868 - taiki-e:s390x-fixme, r=jieyouxu
Update FIXME comment in s390x_unknown_linux_*.rs - Remove comment about "LLVM < 16" since the minimum external LLVM version is 16+ since rust-lang#117947 - Reflect rename of cabi_s390x.rs in rust-lang@030244c (renamed to [abi/call/s390x.rs](rust-lang@030244c#diff-20136d4a18fa0ef9bd4fc2e6f92e88daad6be88bfb156e5702af39ee87ca4879), and it is currently [still in the same location](https://github.com/rust-lang/rust/blob/9e394f551c050ff03c6fc57f190e0761cf0be6e8/compiler/rustc_target/src/abi/call/s390x.rs)). r? ``@cuviper`` ``@rustbot`` label +O-SystemZ
Configuration menu - View commit details
-
Copy full SHA for e383444 - Browse repository at this point
Copy the full SHA e383444View commit details