New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the misleading diagnostic for `let_underscore_drop` on type without `Drop` implementation #130833

Merged

bors merged 1 commit into rust-lang:master from makai410:master

Sep 27, 2024

Contributor

makai410 commented Sep 25, 2024

Closes: #130430
r? rust-lang/diagnostics

rustbot assigned chenyukang

Collaborator

rustbot commented Sep 25, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @chenyukang (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

@rustbot author: the review is finished, PR author should check the comments and take action accordingly
@rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

rustbot added S-waiting-on-review T-compiler labels

Collaborator

rustbot commented Sep 25, 2024

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

compiler-errors approved these changes

View reviewed changes

compiler-errors requested changes

View reviewed changes

src/tools/rust-analyzer/crates/ide-db/src/generated/lints.rs Outdated Show resolved Hide resolved

compiler-errors assigned compiler-errors and unassigned chenyukang

compiler-errors added S-waiting-on-author and removed S-waiting-on-review labels

makai410 requested a review from compiler-errors

September 26, 2024 00:05

rustbot added S-waiting-on-review and removed S-waiting-on-author labels

Member

fee1-dead commented Sep 26, 2024

@bors r+ rollup

Contributor

bors commented Sep 26, 2024

📌 Commit d5657c1 has been approved by fee1-dead

It is now in the queue for this repository.

bors added S-waiting-on-bors and removed S-waiting-on-review labels

Member

fee1-dead commented Sep 26, 2024

@bors r=fee1-dead,compiler-errors

Contributor

bors commented Sep 26, 2024

💡 This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: Bump cc dependency #130720

Contributor

bors commented Sep 26, 2024

📌 Commit d5657c1 has been approved by fee1-dead,compiler-errors

It is now in the queue for this repository.

Member

compiler-errors commented Sep 26, 2024

Please rebase this into one commit; none of this PR's history should need to be synced next time that rust-analyzer does a subtree sync.

bors added S-waiting-on-author and removed S-waiting-on-bors labels

Member

compiler-errors commented Sep 26, 2024

Or you can do (making sure you're on this branch):

git reset HEAD~2
git commit -am "Fix the misleading diagnostic for let_underscore_drop on type without Drop implementation"
# then push with `--force-with-lease`


          Fix the misleading diagnostic for let_underscore_drop on type without…

… Drop implementation

makai410 force-pushed the master branch from d5657c1 to 5892187 Compare

September 26, 2024 02:21

Member

fee1-dead commented Sep 26, 2024

Please rebase this into one commit;

Oops, thanks for catching this! Wasn't looking at the commits log when I reviewed..

Member

compiler-errors commented Sep 26, 2024

@bors r=compiler-errors,fee1-dead

Contributor

bors commented Sep 26, 2024

📌 Commit 5892187 has been approved by compiler-errors,fee1-dead

It is now in the queue for this repository.

bors added S-waiting-on-bors and removed S-waiting-on-author labels

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request


          Rollup merge of rust-lang#130833 - makai410:master, r=compiler-errors…

f1bed97

…,fee1-dead

Fix the misleading diagnostic for `let_underscore_drop` on type without `Drop` implementation

Closes: rust-lang#130430
r? rust-lang/diagnostics

matthiaskrgr mentioned this pull request

Rollup of 7 pull requests #130871

Closed

bors added a commit to rust-lang-ci/rust that referenced this pull request


          Auto merge of rust-lang#130871 - matthiaskrgr:rollup-2cfpxt7, r=matth…

dd8dd7f

…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#130820 (Fix diagnostics for coroutines with () as input.)
 - rust-lang#130833 (Fix the misleading diagnostic for `let_underscore_drop` on type without `Drop` implementation)
 - rust-lang#130845 (Utf8Chunks: add link to Utf8Chunk)
 - rust-lang#130860 (Fix directives for lint-non-snake-case-crate)
 - rust-lang#130861 (Use `mem::offset_of!` for `sockaddr_un.sun_path`)
 - rust-lang#130865 (Use `&raw` in the standard library)
 - rust-lang#130868 (Update FIXME comment in s390x_unknown_linux_*.rs)

r? `@ghost`
`@rustbot` modify labels: rollup

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request


          Rollup merge of rust-lang#130833 - makai410:master, r=compiler-errors…

cc6d328

…,fee1-dead

Fix the misleading diagnostic for `let_underscore_drop` on type without `Drop` implementation

Closes: rust-lang#130430
r? rust-lang/diagnostics

matthiaskrgr mentioned this pull request

Rollup of 5 pull requests #130876

Closed

bors added a commit to rust-lang-ci/rust that referenced this pull request


          Auto merge of rust-lang#130876 - matthiaskrgr:rollup-ntrxdhe, r=matth…

d80c3fe

…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#130820 (Fix diagnostics for coroutines with () as input.)
 - rust-lang#130833 (Fix the misleading diagnostic for `let_underscore_drop` on type without `Drop` implementation)
 - rust-lang#130845 (Utf8Chunks: add link to Utf8Chunk)
 - rust-lang#130860 (Fix directives for lint-non-snake-case-crate)
 - rust-lang#130868 (Update FIXME comment in s390x_unknown_linux_*.rs)

r? `@ghost`
`@rustbot` modify labels: rollup

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request


          Rollup merge of rust-lang#130833 - makai410:master, r=compiler-errors…

66d10f6

…,fee1-dead

Fix the misleading diagnostic for `let_underscore_drop` on type without `Drop` implementation

Closes: rust-lang#130430
r? rust-lang/diagnostics

matthiaskrgr mentioned this pull request

Rollup of 6 pull requests #130878

Closed

bors added a commit to rust-lang-ci/rust that referenced this pull request


          Auto merge of rust-lang#130878 - matthiaskrgr:rollup-npprq87, r=matth…

0c31763

…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#129687 (Implement RFC3137 trim-paths sysroot changes - take 2)
 - rust-lang#130820 (Fix diagnostics for coroutines with () as input.)
 - rust-lang#130833 (Fix the misleading diagnostic for `let_underscore_drop` on type without `Drop` implementation)
 - rust-lang#130845 (Utf8Chunks: add link to Utf8Chunk)
 - rust-lang#130868 (Update FIXME comment in s390x_unknown_linux_*.rs)
 - rust-lang#130873 (rustc_target: Add powerpc64 atomic-related features)

r? `@ghost`
`@rustbot` modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request


          Auto merge of rust-lang#130878 - matthiaskrgr:rollup-npprq87, r=matth…

f44615f

…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#129687 (Implement RFC3137 trim-paths sysroot changes - take 2)
 - rust-lang#130820 (Fix diagnostics for coroutines with () as input.)
 - rust-lang#130833 (Fix the misleading diagnostic for `let_underscore_drop` on type without `Drop` implementation)
 - rust-lang#130845 (Utf8Chunks: add link to Utf8Chunk)
 - rust-lang#130868 (Update FIXME comment in s390x_unknown_linux_*.rs)
 - rust-lang#130873 (rustc_target: Add powerpc64 atomic-related features)

r? `@ghost`
`@rustbot` modify labels: rollup

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request


          Rollup merge of rust-lang#130833 - makai410:master, r=compiler-errors…

ced814e

…,fee1-dead

Fix the misleading diagnostic for `let_underscore_drop` on type without `Drop` implementation

Closes: rust-lang#130430
r? rust-lang/diagnostics

matthiaskrgr mentioned this pull request

Rollup of 10 pull requests #130893

Closed

bors added a commit to rust-lang-ci/rust that referenced this pull request


          Auto merge of rust-lang#130893 - matthiaskrgr:rollup-u4rpfrm, r=matth…

ea37d7e

…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#129687 (Implement RFC3137 trim-paths sysroot changes - take 2)
 - rust-lang#130517 (Add the library workspace to the suggested rust-analyzer config)
 - rust-lang#130820 (Fix diagnostics for coroutines with () as input.)
 - rust-lang#130833 (Fix the misleading diagnostic for `let_underscore_drop` on type without `Drop` implementation)
 - rust-lang#130845 (Utf8Chunks: add link to Utf8Chunk)
 - rust-lang#130850 (Pass Module Analysis Manager to Standard Instrumentations)
 - rust-lang#130868 (Update FIXME comment in s390x_unknown_linux_*.rs)
 - rust-lang#130873 (rustc_target: Add powerpc64 atomic-related features)
 - rust-lang#130879 (Pass correct HirId to late_bound_vars in diagnostic code)
 - rust-lang#130880 (add missing FIXME(const-hack))

r? `@ghost`
`@rustbot` modify labels: rollup

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request


          Rollup merge of rust-lang#130833 - makai410:master, r=compiler-errors…

…,fee1-dead

Fix the misleading diagnostic for `let_underscore_drop` on type without `Drop` implementation

Closes: rust-lang#130430
r? rust-lang/diagnostics

workingjubilee mentioned this pull request

Rollup of 11 pull requests #130902

Closed

tgross35 added a commit to tgross35/rust that referenced this pull request


          Rollup merge of rust-lang#130833 - makai410:master, r=compiler-errors…

6899a8c

…,fee1-dead

Fix the misleading diagnostic for `let_underscore_drop` on type without `Drop` implementation

Closes: rust-lang#130430
r? rust-lang/diagnostics

tgross35 mentioned this pull request

Rollup of 8 pull requests #130903

Closed

GuillaumeGomez mentioned this pull request

Rollup of 11 pull requests #130907

Merged

bors added a commit to rust-lang-ci/rust that referenced this pull request


          Auto merge of rust-lang#130907 - GuillaumeGomez:rollup-423r4i4, r=Gui…

58420a0

…llaumeGomez

Rollup of 11 pull requests

Successful merges:

 - rust-lang#130279 (Document subtleties of `ManuallyDrop`)
 - rust-lang#130517 (Add the library workspace to the suggested rust-analyzer config)
 - rust-lang#130820 (Fix diagnostics for coroutines with () as input.)
 - rust-lang#130833 (Fix the misleading diagnostic for `let_underscore_drop` on type without `Drop` implementation)
 - rust-lang#130845 (Utf8Chunks: add link to Utf8Chunk)
 - rust-lang#130850 (Pass Module Analysis Manager to Standard Instrumentations)
 - rust-lang#130861 (Use `mem::offset_of!` for `sockaddr_un.sun_path`)
 - rust-lang#130862 (rustdoc: do not animate :target when user prefers reduced motion)
 - rust-lang#130868 (Update FIXME comment in s390x_unknown_linux_*.rs)
 - rust-lang#130879 (Pass correct HirId to late_bound_vars in diagnostic code)
 - rust-lang#130880 (add missing FIXME(const-hack))

r? `@ghost`
`@rustbot` modify labels: rollup

bors merged commit d3cb1ce into rust-lang:master

6 checks passed

rustbot added this to the 1.83.0 milestone

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request


          Unrolled build for rust-lang#130833

86ba233

Rollup merge of rust-lang#130833 - makai410:master, r=compiler-errors,fee1-dead

Fix the misleading diagnostic for `let_underscore_drop` on type without `Drop` implementation

Closes: rust-lang#130430
r? rust-lang/diagnostics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors T-compiler