Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parser: better error messages for @ in struct patterns #130725

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Parser: better error messages for @ in struct patterns #130725

merged 1 commit into from
Oct 3, 2024

Conversation

GrigorenkoPV
Copy link
Contributor

@GrigorenkoPV GrigorenkoPV commented Sep 22, 2024 •
edited by workingjubilee
Loading

Fixes #74701

@rustbot
Copy link
Collaborator

rustbot commented Sep 22, 2024

r? @Nadrieril

rustbot has assigned @Nadrieril.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 22, 2024
@Nadrieril
Copy link
Member

Pardon the delay, I was swamped.

This looks good! Thank you

@bors r+

@bors
Copy link
Contributor

bors commented Oct 2, 2024

📌 Commit 9cd668b has been approved by Nadrieril

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 2, 2024
@workingjubilee workingjubilee mentioned this pull request Oct 3, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 3, 2024
@bors
Auto merge of rust-lang#131185 - workingjubilee:rollup-wkcqe2j, r=wor…
8885239 
…kingjubilee

Rollup of 3 pull requests

Successful merges:

 - rust-lang#126930 (Add unstable support for outputting file checksums for use in cargo)
 - rust-lang#130725 (Parser: better error messages for ``@`` in struct patterns)
 - rust-lang#131166 (Fix `target_vendor` for `aarch64-nintendo-switch-freestanding`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b7c33e2 into rust-lang:master Oct 3, 2024
6 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Oct 3, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 3, 2024
@rust-timer
Unrolled build for rust-lang#130725
d659fa4 
Rollup merge of rust-lang#130725 - GrigorenkoPV:@-in-struct-patterns, r=Nadrieril

Parser: better error messages for `@` in struct patterns
@GrigorenkoPV GrigorenkoPV deleted the @-in-struct-patterns branch October 5, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Nadrieril Nadrieril

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.83.0
Development

Successfully merging this pull request may close these issues.

Confusing error message for Foo{ bar @ .. } pattern
4 participants
@GrigorenkoPV @rustbot @Nadrieril @bors