Fix ICE when passing DefId-creating args to legacy_const_generics.

[veluca93]

r? BoxyUwU

Fixes #123077
Fixes #129150

[BoxyUwU]

@bors try

[bors]

⌛ Trying commit 77a3a5e with merge 52464d1...

[BoxyUwU]

@bors try
(pushing commits cancels the try run xd)

[bors]

⌛ Trying commit 193df11 with merge 47af3d0...

[bors]

☀️ Try build successful - checks-actions
Build commit: 47af3d0 (47af3d0de9d26c7deba4cfb203b710cc3f764e91)

[compiler-errors]

@craterbot check

[craterbot]

👌 Experiment pr-130443 created and queued.
🤖 Automatically detected try build 47af3d0
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[bors]

☔ The latest upstream changes (presumably #130674) made this pull request unmergeable. Please resolve the merge conflicts.

[craterbot]

🚧 Experiment pr-130443 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[craterbot]

🎉 Experiment pr-130443 is completed!
📊 3 regressed and 0 fixed (513940 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[rfcbot]

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

[rustbot]

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

[veluca93]

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged. Otherwise, you can ignore this comment.

That's from re-adding the pretty printer as a dep in rustc_ast_lowering.

[BoxyUwU]

@bors r+

[bors]

📌 Commit b462c68 has been approved by BoxyUwU

It is now in the queue for this repository.

[bors]

⌛ Testing commit b462c68 with merge 46e8d20...

[bors]

☀️ Test successful - checks-actions
Approved by: BoxyUwU
Pushing 46e8d20 to master...

[RalfJung]

Was this already a transitive dep, or did this change reduce build parallelism?

[veluca93]

It was a dep through rustc_errors (and it also was a direct dep ~10 days ago: b480f0f)

[rust-timer]

Finished benchmarking commit (46e8d20): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.3%, secondary -3.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.3%	[-2.3%, -2.3%]	1
Improvements ✅ (secondary)	-3.1%	[-3.1%, -3.1%]	1
All ❌✅ (primary)	-2.3%	[-2.3%, -2.3%]	1

Cycles

Results (secondary -10.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-10.3%	[-16.0%, -4.6%]	2
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 791.497s -> 788.11s (-0.43%)
Artifact size: 335.43 MiB -> 335.43 MiB (0.00%)