Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #130027

Closed
wants to merge 27 commits into from

Commits on Aug 9, 2024

  1. call Cargo::configure_linker only for specific commands

    Calling `Cargo::configure_linker` unconditionally slows down certain
    commands (e.g., "check" command) without providing any benefit.
    
    Signed-off-by: onur-ozkan <[email protected]>
    onur-ozkan committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    9a29081 View commit details
    Browse the repository at this point in the history
  2. don't try to find target tools on certain commands

    For commands like check/clean there is no need to check for target tools.
    Avoiding this check can also speed up the process.
    
    Signed-off-by: onur-ozkan <[email protected]>
    onur-ozkan committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    94fbe14 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2024

  1. Configuration menu
    Copy the full SHA
    2dbc976 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Add a run-make test for checking that certain rustc_ crates build o…

    …n stable
    Kobzol authored and lqd committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    893413d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7957140 View commit details
    Browse the repository at this point in the history
  3. run test in tmp dir and emit artifacts there

    otherwise the test would build in the source root's `target` folder
    lqd committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    d9794a9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2190c28 View commit details
    Browse the repository at this point in the history
  5. separate the crates to test from the test setup

    it'll be easier to see and update the list: the other cmd args
    can just be ignored
    lqd committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    0577035 View commit details
    Browse the repository at this point in the history
  6. remove unneeded type ascription

    lqd committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    f1df0c5 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2024

  1. Configuration menu
    Copy the full SHA
    bb56eeb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4ee58db View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3541000 View commit details
    Browse the repository at this point in the history
  4. remove outdated FIXME

    RalfJung committed Sep 1, 2024
    Configuration menu
    Copy the full SHA
    09783d0 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    cc38581 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2024

  1. address review comments

    lqd committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    a178559 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Pin memchr to 2.5.0 in the library rather than rustc_ast

    The latest versions of `memchr` experience LTO-related issues when
    compiling for windows-gnu [1], so needs to be pinned. The issue is
    present in the standard library.
    
    `memchr` has been pinned in `rustc_ast`, but since the workspace was
    recently split, this pin no longer has any effect on library crates.
    
    Resolve this by adding `memchr` as an _unused_ dependency in `std`,
    pinned to 2.5. Additionally, remove the pin in `rustc_ast` to allow
    non-library crates to upgrade to the latest version.
    
    Link: rust-lang#127890 [1]
    tgross35 committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    8f0ea94 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9c671a1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    07c0585 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. use words that make sense

    Co-authored-by: Jubilee <[email protected]>
    RalfJung and workingjubilee authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    57edda7 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. Configuration menu
    Copy the full SHA
    3699e93 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#119229 - mati865:update-mingw-toolchain, r=…

    …jieyouxu,petrochenkov
    
    Update mingw-w64 + GNU toolchain
    
    The list of packaged tools and their versions is available at: https://github.com/niXman/mingw-builds-binaries/releases/tag/14.1.0-rt_v12-rev0
    
    Fixes: rust-lang#112368
    GuillaumeGomez authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    29abbda View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#128871 - onur-ozkan:128180, r=Kobzol

    bypass linker configuration and cross target check for specific commands
    
    Avoids configuring the linker and checking cross-target-specific tools unless necessary.
    
    Resolves rust-lang#128180
    
    cc `@ChrisDenton`
    GuillaumeGomez authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    f1f9d43 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#128939 - bjorn3:windows_cg_clif_component, …

    …r=albertlarsan68
    
    Distribute rustc_codegen_cranelift for Windows
    
    With support for raw-dylib recently added to cg_clif, and inline assembly support working on Windows for quite a while now, all blockers for distributing cg_clif on Windows that I mentioned in rust-lang#81746 (comment) are fixed now.
    GuillaumeGomez authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    78a64af View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#129529 - lqd:stable-new-solver, r=Kobzol

    Add test to build crates used by r-a on stable
    
    r? ``@Kobzol``
    
    I've opened other PRs for this one to work and they've landed already. I cherry-picked your commit, and added the last remaining pieces we needed I think.
    GuillaumeGomez authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    530e577 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#129624 - tgross35:cargo-update, r=Mark-Simu…

    …lacrum
    
    Adjust `memchr` pinning and run `cargo update`
    
    try-job: x86_64-mingw
    GuillaumeGomez authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    8adef95 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#129835 - RalfJung:float-tests, r=workingjub…

    …ilee
    
    enable const-float-classify test, and test_next_up/down on 32bit x86
    
    The  test_next_up/down tests have been disabled on all 32bit x86 targets, which goes too far -- they should definitely work on our (tier 1) i686 target, it is only without SSE that we might run into trouble due to rust-lang#114479. However, I cannot reproduce that trouble any more -- maybe that got fixed by rust-lang#123351?
    
    The  const-float-classify test relied on const traits "because we can", and got disabled when const traits got removed. That's an unfortunate reduction in test coverage of our float functionality, so let's restore the test in a way that does not rely on const traits.
    
    The const-float tests are actually testing runtime behavior as well, and I don't think that runtime behavior is covered anywhere else. Probably they shouldn't be called "const-float", but we don't have a `tests/ui/float` folder... should I create one and move them there? Are there any other ui tests that should be moved there?
    
    I also removed some FIXME referring to not use x87 for Rust-to-Rust-calls -- that has happened in rust-lang#123351 so this got fixed indeed. Does that mean we can simplify all that float code again? I am not sure how to test it. Is running the test suite with an i586 target enough?
    
    Cc `@tgross35` `@workingjubilee`
    GuillaumeGomez authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    a38f6d8 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#130009 - notriddle:notriddle/trailing-arrow…

    …, r=lolbinarycat,GuillaumeGomez
    
    rustdoc-search: allow trailing `Foo ->` arg search
    
    Fixes rust-lang#129710
    GuillaumeGomez authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    0ed26b5 View commit details
    Browse the repository at this point in the history