-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove #[macro_use] extern crate tracing
from rustc_codegen_gcc
.
#129768
Remove #[macro_use] extern crate tracing
from rustc_codegen_gcc
.
#129768
Conversation
So that `tracing` is treated more like `smallvec` and `tempfile`, i.e. explicitly mentioned in the `Cargo.toml` file.
Failed to set assignee to
|
Some changes occurred in compiler/rustc_codegen_gcc |
Background: I have been removing |
Looks good to me. I'll just wait for @antoyo to confirm before approving it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am against this change as this brings a number of unneeded dependencies.
If there's a way to not bring any new dependency, I would be OK with this.
There is something going on that I don't understand here. I tried making a trivial crate with this [package]
name = "tracing-test"
version = "0.1.0"
edition = "2021"
[dependencies]
tracing = "0.1" and this #[macro_use]
extern crate tracing;
fn main() {
info!("Hello, world!");
} and the How does the |
Maybe this crate is provided the same way as the other rustc crates like |
So that
tracing
is treated more likesmallvec
andtempfile
, i.e. explicitly mentioned in theCargo.toml
file.r? @antoyo