Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin cc to 1.0.105 #129290

Merged
merged 1 commit into from
Aug 25, 2024
Merged

Pin cc to 1.0.105 #129290

merged 1 commit into from
Aug 25, 2024

Conversation

tgross35
Copy link
Contributor

cc 1.0.106 removes support for Visual Studio 12. Pin to 1.0.105 so we don't drop support yet.

Fixes: #128722 (comment)

r? @Mark-Simulacrum
Cc @dpaoliello

@tgross35
Pin cc to 1.0.105
a5f6c15 
`cc` 1.0.106 removes support for Visual Studio 12. Pin to 1.0.105 so we
don't drop support yet.

Fixes: rust-lang#128722 (comment)
@rustbot
Copy link
Collaborator

rustbot commented Aug 20, 2024

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 20, 2024
@tgross35 tgross35 mentioned this pull request Aug 20, 2024
Merged
@klensy
Copy link
Contributor

klensy commented Aug 20, 2024

Anyway, rust can't be (fully, building llvm too) bootstraped with msvc 2013, as llvm requries (https://llvm.org/docs/GettingStarted.html) Visual Studio 2019 16.7 minimum,

@tgross35
Copy link
Contributor Author

Oh, that is interesting. I assume this sort of happened naturally with the minimum supported version bump to Windows 10 anyway.

Per #128722 (comment) bumping the version probably isn't actually an issue, it just shouldn't happen quietly.

@ChrisDenton
Copy link
Member

Note that all "support" means in this context is that cc won't automatically find it. It can still pick it up from the environment. That's different from whether or not it works. Which it may or may not do, I've never tried.

That said, this feels like a question for t-compiler.

@ChrisDenton
Copy link
Member

Personally I think the documentation issue can be solved separately. Adding it to release notes is good enough for the PR to land. We also don't document minium versions of binutils etc on the platform support page. Maybe we should! But that's a pre-existing issue and bumping cc or not doesn't change that.

@jieyouxu jieyouxu mentioned this pull request Aug 20, 2024
Open
@jieyouxu
Copy link
Member

jieyouxu commented Aug 20, 2024 •
edited
Loading

Personally I think the documentation issue can be solved separately. Adding it to release notes is good enough for the PR to land. We also don't document minium versions of binutils etc on the platform support page. Maybe we should! But that's a pre-existing issue and bumping cc or not doesn't change that.

Opened a new issue #129307 to track the lack of build tool version docs. We can nominate the cc bump dropping support for VS 2013 for a T-compiler FCP if desired, but it might want to happen in a different PR that does the bump explicitly w/ relnotes.

@Mark-Simulacrum
Copy link
Member

@bors r+

I'm going to approve this as it's basically a revert. It looks like there are some thoughts on how to better track this, but those can be addressed in followup.

@bors
Copy link
Contributor

bors commented Aug 24, 2024

📌 Commit a5f6c15 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 24, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 24, 2024
@matthiaskrgr
Rollup merge of rust-lang#129290 - tgross35:pin-cc, r=Mark-Simulacrum
88edf31 
Pin `cc` to 1.0.105

`cc` 1.0.106 removes support for Visual Studio 12. Pin to 1.0.105 so we don't drop support yet.

Fixes: rust-lang#128722 (comment)
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 24, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 24, 2024
@bors
Auto merge of rust-lang#129516 - matthiaskrgr:rollup-u13wr8q, r=matth…
dd51090 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#128596 (stabilize const_fn_floating_point_arithmetic)
 - rust-lang#129199 (make writes_through_immutable_pointer a hard error)
 - rust-lang#129246 (Retroactively feature gate `ConstArgKind::Path`)
 - rust-lang#129290 (Pin `cc` to 1.0.105)
 - rust-lang#129323 (Implement `ptr::fn_addr_eq`)
 - rust-lang#129500 (remove invalid `TyCompat` relation for effects)
 - rust-lang#129501 (panicking: improve hint for Miri's RUST_BACKTRACE behavior)
 - rust-lang#129505 (interpret: ImmTy: tighten sanity checks in offset logic)
 - rust-lang#129509 (Add a hack to workaround MSVC CI issues)
 - rust-lang#129510 (Fix `elided_named_lifetimes` in code)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Aug 24, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 24, 2024
@bors
Auto merge of rust-lang#129521 - matthiaskrgr:rollup-uigv77m, r=matth…
313db53 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#128596 (stabilize const_fn_floating_point_arithmetic)
 - rust-lang#129199 (make writes_through_immutable_pointer a hard error)
 - rust-lang#129246 (Retroactively feature gate `ConstArgKind::Path`)
 - rust-lang#129290 (Pin `cc` to 1.0.105)
 - rust-lang#129323 (Implement `ptr::fn_addr_eq`)
 - rust-lang#129500 (remove invalid `TyCompat` relation for effects)
 - rust-lang#129501 (panicking: improve hint for Miri's RUST_BACKTRACE behavior)
 - rust-lang#129505 (interpret: ImmTy: tighten sanity checks in offset logic)
 - rust-lang#129510 (Fix `elided_named_lifetimes` in code)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 25, 2024
@bors
Auto merge of rust-lang#129521 - matthiaskrgr:rollup-uigv77m, r=matth…
3557abf 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#128596 (stabilize const_fn_floating_point_arithmetic)
 - rust-lang#129199 (make writes_through_immutable_pointer a hard error)
 - rust-lang#129246 (Retroactively feature gate `ConstArgKind::Path`)
 - rust-lang#129290 (Pin `cc` to 1.0.105)
 - rust-lang#129323 (Implement `ptr::fn_addr_eq`)
 - rust-lang#129500 (remove invalid `TyCompat` relation for effects)
 - rust-lang#129501 (panicking: improve hint for Miri's RUST_BACKTRACE behavior)
 - rust-lang#129505 (interpret: ImmTy: tighten sanity checks in offset logic)
 - rust-lang#129510 (Fix `elided_named_lifetimes` in code)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 25, 2024
@bors
Auto merge of rust-lang#129521 - matthiaskrgr:rollup-uigv77m, r=matth…
717aec0 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#128596 (stabilize const_fn_floating_point_arithmetic)
 - rust-lang#129199 (make writes_through_immutable_pointer a hard error)
 - rust-lang#129246 (Retroactively feature gate `ConstArgKind::Path`)
 - rust-lang#129290 (Pin `cc` to 1.0.105)
 - rust-lang#129323 (Implement `ptr::fn_addr_eq`)
 - rust-lang#129500 (remove invalid `TyCompat` relation for effects)
 - rust-lang#129501 (panicking: improve hint for Miri's RUST_BACKTRACE behavior)
 - rust-lang#129505 (interpret: ImmTy: tighten sanity checks in offset logic)
 - rust-lang#129510 (Fix `elided_named_lifetimes` in code)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2a7f2da into rust-lang:master Aug 25, 2024
6 checks passed
@rustbot rustbot added this to the 1.82.0 milestone Aug 25, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Aug 25, 2024
@rust-timer
Unrolled build for rust-lang#129290
44289e3 
Rollup merge of rust-lang#129290 - tgross35:pin-cc, r=Mark-Simulacrum

Pin `cc` to 1.0.105

`cc` 1.0.106 removes support for Visual Studio 12. Pin to 1.0.105 so we don't drop support yet.

Fixes: rust-lang#128722 (comment)
@tgross35 tgross35 deleted the pin-cc branch September 27, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.82.0
Development

Successfully merging this pull request may close these issues.
7 participants
@tgross35 @rustbot @klensy @ChrisDenton @jieyouxu @Mark-Simulacrum @bors