Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preliminary cleanup of WitnessPat hoisting/printing #128536

Merged
merged 11 commits into from
Aug 11, 2024
Merged

Preliminary cleanup of WitnessPat hoisting/printing #128536

merged 11 commits into from
Aug 11, 2024

Commits on Aug 7, 2024

  1. Break up print::Pat printing into several helper functions

    @Zalathar
    Zalathar committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    ccfd94e View commit details
    Browse the repository at this point in the history

  2. Unify Variant and Leaf into print::PatKind::StructLike

    @Zalathar
    Zalathar committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    74f76ae View commit details
    Browse the repository at this point in the history

  3. Remove an impossible case under EnumInfo::NotEnum

    @Zalathar
    Zalathar committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    4cd8005 View commit details
    Browse the repository at this point in the history

  4. Replace an unnecessary slice pattern with has_dot_dot: bool

    @Zalathar
    Zalathar committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    e98e19e View commit details
    Browse the repository at this point in the history

  5. Split out a hoist helper in hoist_witness_pat

    @Zalathar
    Zalathar committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    7f48851 View commit details
    Browse the repository at this point in the history

  6. Split out hoisting/printing of box patterns

    @Zalathar
    Zalathar committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    a5ed6fb View commit details
    Browse the repository at this point in the history

  7. Simplify hoisting of struct-like patterns

    @Zalathar
    Zalathar committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    c764bea View commit details
    Browse the repository at this point in the history

  8. Simplify hoisting of array/slice patterns 

    We can replace some tricky iterator-mutation code with a much simpler version
that uses `while let` to shrink a slice.

We also check whether a subpattern would be a wildcard _before_ hoisting it,
which will be very useful when trying to get rid of `print::PatKind` later.
    @Zalathar
    Zalathar committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    a245bfa View commit details
    Browse the repository at this point in the history

  9. Simplify hoisting of ref patterns (& and &mut)

    @Zalathar
    Zalathar committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    582208b View commit details
    Browse the repository at this point in the history

  10. Avoid using ty::tls::with in write_struct_like

    @Zalathar
    Zalathar committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    29245ec View commit details
    Browse the repository at this point in the history

  11. Use TyCtxt::is_diagnostic_item

    @Zalathar
    Zalathar committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    482412c View commit details
    Browse the repository at this point in the history