bootstrap: fix bug preventing the use of custom targets #128283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @albertlarsan68 (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
S-waiting-on-review
|
This PR modifies If appropriate, please update |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
☔ The latest upstream changes (presumably #125443) made this pull request unmergeable. Please resolve the merge conflicts. |
albertlarsan68
added
S-waiting-on-author
lolbinarycat
force-pushed
the
bootstrap-custom-target
branch
from
5ba7b62
to
5f0b85a
Compare
This comment has been minimized.
This comment has been minimized.
|
@rustbot review |
rustbot
added
S-waiting-on-review
albertlarsan68
requested changes
Aug 1, 2024
Comment on lines
519
to
523
| /*if let Some(ref p) = self.file.as_ref { | ||
| Some(Path::new(p)) | ||
| } else { | ||
| None | ||
| }*/ |
There was a problem hiding this comment.
Can you remove this commented out code please?
|
r=@albertlarsan68 |
rustbot
added
S-waiting-on-review
albertlarsan68
approved these changes
Aug 2, 2024
There was a problem hiding this comment.
LGTM, r=me after a squash (https://rustc-dev-guide.rust-lang.org/git.html#squash-your-commits)
albertlarsan68
added
S-waiting-on-author
the bug was caused by two factors: 1. only checking the RUST_TARGET_PATH form, not the full filepath form 2. indirectly trying to use the Debug presentation to get the file path
lolbinarycat
force-pushed
the
bootstrap-custom-target
branch
from
f09c706
to
6264d2e
Compare
|
r=@albertlarsan68 done |
|
@rustbot review |
rustbot
added
S-waiting-on-review
|
Thanks for the PR! |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 3, 2024
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#127921 (Stabilize unsafe extern blocks (RFC 3484)) - rust-lang#128283 (bootstrap: fix bug preventing the use of custom targets) - rust-lang#128530 (Implement `UncheckedIterator` directly for `RepeatN`) - rust-lang#128551 (chore: refactor backtrace style in panic) - rust-lang#128573 (Simplify `body` usage in rustdoc) - rust-lang#128581 (Assert that all attributes are actually checked via `CheckAttrVisitor` and aren't accidentally usable on completely unrelated HIR nodes) - rust-lang#128603 (Update run-make/used to use `any_symbol_contains`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 3, 2024
Rollup merge of rust-lang#128283 - lolbinarycat:bootstrap-custom-target, r=albertlarsan68 bootstrap: fix bug preventing the use of custom targets the bug was caused by two factors: 1. only checking the RUST_TARGET_PATH form, not the full filepath form 2. indirectly trying to use the Debug presentation to get the file path
ratankaliani
added a commit
to succinctlabs/rust
that referenced
this pull request
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the bug was caused by two factors: