Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 7 pull requests #127701

Closed
wants to merge 40 commits into from
Closed

Rollup of 7 pull requests #127701

wants to merge 40 commits into from

Conversation

jhpratt
Copy link
Member

@jhpratt jhpratt commented Jul 13, 2024

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

CastilloDel and others added 30 commits April 14, 2024 11:35
@CastilloDel
Run filecheck on dest-prop/branch.rs
6bd68fc
@CastilloDel
Run filecheck on dest-prop/copy_propagation.rs
f238eba
@CastilloDel
Run filecheck on dest-prop/cycle.rs
853311c
@CastilloDel
Run filecheck on dest-prop/dead_stores_79191.rs and dead_stores_bette…
0692090 
…r.rs
@CastilloDel
Run filecheck on dest-prop/simple.rs
f0f867e
@CastilloDel
Acknowledge comments
2d5a483
@NobodyXu
Initial implementation of annoymous_pipe
04eed9b 
Signed-off-by: Jiahao XU <[email protected]>
@NobodyXu
Fix compilation errors
72bda33 
Signed-off-by: Jiahao XU <[email protected]>
@NobodyXu
Implement validation in TryFrom<OwnedFd> for PIpe* on unix
42e8beb 
Signed-off-by: Jiahao XU <[email protected]>
@NobodyXu
Move the mod pipe to std::net
e170c78 
Signed-off-by: Jiahao XU <[email protected]>
@NobodyXu
Fix typo
473fbce 
Signed-off-by: Jiahao XU <[email protected]>
@NobodyXu
Fix tidy errors
97626b6 
Signed-off-by: Jiahao XU <[email protected]>
@NobodyXu
Validate pipe in TryFrom<OwnedHandle> for Pipe*
d60438f 
Signed-off-by: Jiahao XU <[email protected]>
@NobodyXu
Refactor: Extract new method FileDesc::get_access_mode
b7af685 
ALso fixed a bug in the original implementation

Signed-off-by: Jiahao XU <[email protected]>
@NobodyXu
Add testing for anonymous pipe
4c6b6bb 
Signed-off-by: Jiahao XU <[email protected]>
@NobodyXu
Refactor: Put mod unix & windows into separate files
594abec 
Signed-off-by: Jiahao XU <[email protected]>
@NobodyXu
Fix anonymous_pipe impl for not supported targets
d9f0980 
Signed-off-by: Jiahao XU <[email protected]>
@NobodyXu
Optimize: Add #[inline] to very simple function
6c755a3 
Signed-off-by: Jiahao XU <[email protected]>
@onur-ozkan
use "bootstrap" instead of "rustbuild" in comments and docs
4819270 
Signed-off-by: onur-ozkan <[email protected]>
@nnethercote
Clear inner_attr_ranges regularly.
99721c8 
There's a comment saying we don't do it for performance reasons, but it
doesn't actually affect performance.

The commit also tweaks the control flow, to make clearer that two code
paths are mutually exclusive.
@NobodyXu
Refactor: Make AcessMode an enum`
d15cee5 
Signed-off-by: Jiahao XU <[email protected]>
@NobodyXu @a1phyr
Update mod.rs
e22dd1a 
Co-authored-by: Alphyr <[email protected]>
@NobodyXu
Move std::net::pip* to a new mod std::pipe
100fe5c 
Signed-off-by: Jiahao XU <[email protected]>
@NobodyXu
Remove use of macro_rules!
62b846e 
Signed-off-by: Jiahao XU <[email protected]>
@NobodyXu
Replace TryFrom<Owned*> with From
4547b30 
Signed-off-by: Jiahao XU <[email protected]>
@NobodyXu
Fix compilation on non-unix, non-windows targets
72f5999 
Signed-off-by: Jiahao XU <[email protected]>
@NobodyXu
Fix compilation error on unsupported target
45886cc 
Signed-off-by: Jiahao XU <[email protected]>
@saethlin
Use ManuallyDrop in BufWriter::into_parts
7fc6943
@notriddle
Add URL and crate_name to test cases
4d35754
@notriddle
rustdoc: rename issue-\d+.rs tests to have meaningful names
17419f6
@jhpratt
Rollup merge of rust-lang#127477 - nnethercote:tweak-inner_attr_range…
6982f91 
…s, r=petrochenkov

Clear `inner_attr_ranges` regularly.

There's a comment saying we don't do it for performance reasons, but it doesn't actually affect performance.

The commit also tweaks the control flow, to make clearer that two code paths are mutually exclusive.

r? ```@petrochenkov```
@jhpratt
Rollup merge of rust-lang#127659 - saethlin:manually-drop-bufwriter, …
e6af63a 
…r=joboet

Use ManuallyDrop in BufWriter::into_parts

The fact that `mem::forget` takes by value means that it interacts very poorly with Stacked Borrows; generally users think of calling it as a no-op, but in Stacked Borrows, the field retagging tends to cause surprise tag invalidation.
@jhpratt
Rollup merge of rust-lang#127671 - notriddle:notriddle/issue-d, r=Mar…
6e18eaf 
…k-Simulacrum

rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 8)

Follow up

* rust-lang#116214
* rust-lang#116432
* rust-lang#116824
* rust-lang#118105
* rust-lang#119561
* rust-lang#123574
* rust-lang#125382

As always, it's easier to review the commits one at a time. Don't use the Files Changed tab. It's confusing.
@jhpratt
Rollup merge of rust-lang#127677 - onur-ozkan:use-correct-modes, r=Ko…
7a165e5 
…bzol

using correct tool mode for `run-make-support` crate

We don't need to ensure std (and rustc) for testing run-make-support's unit tests. Using stage 0 compiler is already enough and speeds up `x test run-make-support` invocations on a clean build.
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc O-unix Operating system: Unix-like O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jul 13, 2024
@jhpratt
Copy link
Member Author

jhpratt commented Jul 13, 2024

@bors r+ rollup=never p=7

@bors
Copy link
Contributor

bors commented Jul 13, 2024

📌 Commit 7a165e5 has been approved by jhpratt

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 13, 2024
@workingjubilee
Copy link
Member

I think #127677 might have been the culprit.

@workingjubilee
Copy link
Member

Absolutely no evidence for that tho'.

@workingjubilee
Copy link
Member

( I think this rollup should probably proceed anyways though because if it is, this failing will pretty-much confirm it. )

bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 14, 2024
@bors
Auto merge of rust-lang#127701 - jhpratt:rollup-n50bfva, r=jhpratt
79b4b57 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#122300 (Add FileCheck annotations to mir-opt/dest-prop tests)
 - rust-lang#127153 (Initial implementation of anonymous_pipe API)
 - rust-lang#127434 (use "bootstrap" instead of "rustbuild" in comments and docs)
 - rust-lang#127477 (Clear `inner_attr_ranges` regularly.)
 - rust-lang#127659 (Use ManuallyDrop in BufWriter::into_parts)
 - rust-lang#127671 (rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 8))
 - rust-lang#127677 (using correct tool mode for `run-make-support` crate)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Contributor

bors commented Jul 14, 2024

⌛ Testing commit 7a165e5 with merge 79b4b57...

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-aux failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Contributor

bors commented Jul 14, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 14, 2024
@workingjubilee workingjubilee mentioned this pull request Jul 14, 2024
Merged
@jhpratt jhpratt deleted the rollup-n50bfva branch July 14, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc O-unix Operating system: Unix-like O-windows Operating system: Windows rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.