From 0fe65aa68fb097d0c653e64cf7331d990618c032 Mon Sep 17 00:00:00 2001 From: Samuel Marks <807580+SamuelMarks@users.noreply.github.com> Date: Thu, 11 Jul 2024 20:06:48 -0400 Subject: [PATCH 1/3] [library/std/src/process.rs] `PartialEq` & `Eq` for `ExitCode` --- library/std/src/process.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/library/std/src/process.rs b/library/std/src/process.rs index f351dab78dc1a..727f8f5ceb660 100644 --- a/library/std/src/process.rs +++ b/library/std/src/process.rs @@ -1979,7 +1979,7 @@ impl crate::error::Error for ExitStatusError {} /// ExitCode::SUCCESS /// } /// ``` -#[derive(Clone, Copy, Debug)] +#[derive(Clone, Copy, Debug, PartialEq, Eq)] #[stable(feature = "process_exitcode", since = "1.61.0")] pub struct ExitCode(imp::ExitCode); From 76f352ceb6eab4bf97be3aa3fb7f01d1fd2c6346 Mon Sep 17 00:00:00 2001 From: Samuel Marks <807580+SamuelMarks@users.noreply.github.com> Date: Thu, 5 Sep 2024 11:37:05 -0500 Subject: [PATCH 2/3] [library/std/src/process.rs] Update docstring with @joshtriplett's replacement text --- library/std/src/process.rs | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/library/std/src/process.rs b/library/std/src/process.rs index 727f8f5ceb660..c25383405c43b 100644 --- a/library/std/src/process.rs +++ b/library/std/src/process.rs @@ -1937,10 +1937,14 @@ impl crate::error::Error for ExitStatusError {} /// to its parent under normal termination. /// /// `ExitCode` is intended to be consumed only by the standard library (via -/// [`Termination::report()`]), and intentionally does not provide accessors like -/// `PartialEq`, `Eq`, or `Hash`. Instead the standard library provides the -/// canonical `SUCCESS` and `FAILURE` exit codes as well as `From for -/// ExitCode` for constructing other arbitrary exit codes. +/// [`Termination::report()`]). For forwards compatibility with potentially +/// unusual targets, this type currently does not provide `Eq`, `Hash`, or +/// access to the raw value. This type does provide `PartialEq` for +/// comparison, but note that there may potentially be multiple failure +/// codes, some of which will _not_ compare equal to `ExitCode::FAILURE`. +/// The standard library provides the canonical `SUCCESS` and `FAILURE` +/// exit codes as well as `From for ExitCode` for constructing other +/// arbitrary exit codes. /// /// # Portability /// From 2f0eb5f44d79ae5a40cf6c7ec1dff5659eda9405 Mon Sep 17 00:00:00 2001 From: Samuel Marks <807580+SamuelMarks@users.noreply.github.com> Date: Fri, 6 Sep 2024 12:32:00 -0500 Subject: [PATCH 3/3] [library/std/src/process.rs] Remove `Eq` `derive` --- library/std/src/process.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/library/std/src/process.rs b/library/std/src/process.rs index c25383405c43b..2c964648f0c2e 100644 --- a/library/std/src/process.rs +++ b/library/std/src/process.rs @@ -1983,7 +1983,7 @@ impl crate::error::Error for ExitStatusError {} /// ExitCode::SUCCESS /// } /// ``` -#[derive(Clone, Copy, Debug, PartialEq, Eq)] +#[derive(Clone, Copy, Debug, PartialEq)] #[stable(feature = "process_exitcode", since = "1.61.0")] pub struct ExitCode(imp::ExitCode);