-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bootstrap command refactoring: improve debuggability (step 5) #127450
Commits on Jul 12, 2024
-
Move
DropBomb
fromrun-make-support
tobuild_helper
So that it can be also used in bootstrap.
Configuration menu - View commit details
-
Copy full SHA for 97990a4 - Browse repository at this point
Copy the full SHA 97990a4View commit details -
Configure test execution for the
build_helper
crate in bootstrapTo enable the previously moved `DropBomb` tests.
Configuration menu - View commit details
-
Copy full SHA for 49f54b8 - Browse repository at this point
Copy the full SHA 49f54b8View commit details -
Store full arm location in
DropBomb
Before, only the line was stored. This was enough for run-make tests, since these mostly only contain a single `rmake.rs` file, but not for bootstrap.
Configuration menu - View commit details
-
Copy full SHA for 042473f - Browse repository at this point
Copy the full SHA 042473fView commit details -
Make
command
field ofBootstrapCommand
private to force access to…… it through the `as_command_mut` method This will be useful for disarming drop bombs when the inner command is accessed.
Configuration menu - View commit details
-
Copy full SHA for a1626d7 - Browse repository at this point
Copy the full SHA a1626d7View commit details -
Add
DropBomb
toBootstrapCommand
This makes it harder to accidentally forget to execute a created command in bootstrap.
Configuration menu - View commit details
-
Copy full SHA for cefd5b3 - Browse repository at this point
Copy the full SHA cefd5b3View commit details -
Print command creation and execution location when it fails
This should make it quicker to debug command failures.
Configuration menu - View commit details
-
Copy full SHA for 542344f - Browse repository at this point
Copy the full SHA 542344fView commit details -
Improve the
Debug
representation ofBootstrapCommand
Avoid printing useless information in the `Debug` output.
Configuration menu - View commit details
-
Copy full SHA for fdf1477 - Browse repository at this point
Copy the full SHA fdf1477View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9634633 - Browse repository at this point
Copy the full SHA 9634633View commit details -
Fix a case where a RustBook command is potentially not executed
We can move the command creation to a block where it is clear that the command will be executed.
Configuration menu - View commit details
-
Copy full SHA for 8ee18d6 - Browse repository at this point
Copy the full SHA 8ee18d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for ebb3089 - Browse repository at this point
Copy the full SHA ebb3089View commit details -
Disarm drop bombs for unexecuted test Cargo commands
The code for running tests uses a custom command machinery because it streams the output of the command. We thus need to mark the command as executed in a dry run, to avoid a drop bomb panic.
Configuration menu - View commit details
-
Copy full SHA for 0cab962 - Browse repository at this point
Copy the full SHA 0cab962View commit details -
Simplify command executions for plain source tarballs
If we're in dry run mode, the command will return an empty string, so we can just execute it.
Configuration menu - View commit details
-
Copy full SHA for 1089de4 - Browse repository at this point
Copy the full SHA 1089de4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 823ea0e - Browse repository at this point
Copy the full SHA 823ea0eView commit details -
Test
build_helper
with the stage 0 compilerThere is no need to build a stage N toolchain for testing it.
Configuration menu - View commit details
-
Copy full SHA for 72c3540 - Browse repository at this point
Copy the full SHA 72c3540View commit details
Commits on Jul 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0cce0bb - Browse repository at this point
Copy the full SHA 0cce0bbView commit details