Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bootstrap command refactoring: improve debuggability (step 5) #127450

Merged
merged 15 commits into from
Jul 13, 2024

Commits on Jul 12, 2024

  1. Move DropBomb from run-make-support to build_helper

    So that it can be also used in bootstrap.
    Kobzol committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    97990a4 View commit details
    Browse the repository at this point in the history
  2. Configure test execution for the build_helper crate in bootstrap

    To enable the previously moved `DropBomb` tests.
    Kobzol committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    49f54b8 View commit details
    Browse the repository at this point in the history
  3. Store full arm location in DropBomb

    Before, only the line was stored. This was enough for run-make tests, since these mostly only contain a single `rmake.rs` file, but not for bootstrap.
    Kobzol committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    042473f View commit details
    Browse the repository at this point in the history
  4. Make command field of BootstrapCommand private to force access to…

    … it through the `as_command_mut` method
    
    This will be useful for disarming drop bombs when the inner command is accessed.
    Kobzol committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    a1626d7 View commit details
    Browse the repository at this point in the history
  5. Add DropBomb to BootstrapCommand

    This makes it harder to accidentally forget to execute a created command in bootstrap.
    Kobzol committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    cefd5b3 View commit details
    Browse the repository at this point in the history
  6. Print command creation and execution location when it fails

    This should make it quicker to debug command failures.
    Kobzol committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    542344f View commit details
    Browse the repository at this point in the history
  7. Improve the Debug representation of BootstrapCommand

    Avoid printing useless information in the `Debug` output.
    Kobzol committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    fdf1477 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    9634633 View commit details
    Browse the repository at this point in the history
  9. Fix a case where a RustBook command is potentially not executed

    We can move the command creation to a block where it is clear that the command will be executed.
    Kobzol committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    8ee18d6 View commit details
    Browse the repository at this point in the history
  10. Remove unused rustdoc command

    Kobzol committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    ebb3089 View commit details
    Browse the repository at this point in the history
  11. Disarm drop bombs for unexecuted test Cargo commands

    The code for running tests uses a custom command machinery because it streams the output of the command. We thus need to mark the command as executed in a dry run, to avoid a drop bomb panic.
    Kobzol committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    0cab962 View commit details
    Browse the repository at this point in the history
  12. Simplify command executions for plain source tarballs

    If we're in dry run mode, the command will return an empty string, so we can just execute it.
    Kobzol committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    1089de4 View commit details
    Browse the repository at this point in the history
  13. Modify FIXME comment

    Kobzol committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    823ea0e View commit details
    Browse the repository at this point in the history
  14. Test build_helper with the stage 0 compiler

    There is no need to build a stage N toolchain for testing it.
    Kobzol committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    72c3540 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2024

  1. Configuration menu
    Copy the full SHA
    0cce0bb View commit details
    Browse the repository at this point in the history