borrowck: classify expressions as assignees, uses or both #12733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I canceled the build, @nikomatsakis seemed to have concerns |
- Repurposes `MoveData.assignee_ids` to mean only `=` but not `+=`, so that borrowck effectively classifies all expressions into assignees, uses or both. - Removes two `span_err` in liveness analysis, which are now borrowck's responsibilities. Closes rust-lang#12527.
bors
added a commit
that referenced
this pull request
Mar 9, 2014
- Repurposes `MoveData.assignee_ids` to mean only `=` but not `+=`, so
that borrowck effectively classifies all expressions into assignees,
uses or both.
- Removes two `span_err` in liveness analysis, which are now borrowck's
responsibilities.
Closes #12527.
bors
added a commit
that referenced
this pull request
Mar 10, 2014
- Repurposes `MoveData.assignee_ids` to mean only `=` but not `+=`, so
that borrowck effectively classifies all expressions into assignees,
uses or both.
- Removes two `span_err` in liveness analysis, which are now borrowck's
responsibilities.
Closes #12527.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
May 2, 2024
suppress `readonly_write_lock` for underscore-prefixed bindings Fixes rust-lang#12733 Unsure if there's a better way to prevent this kind of false positive but this is the one that made most sense to me. In my experience, prefixing bindings with an underscore is the usual way to name variables that aren't used and that exist purely for executing drop code at the end of the scope. ------- changelog: suppress [`readonly_write_lock`] for underscore-prefixed bindings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MoveData.assignee_idsto mean only=but not+=, sothat borrowck effectively classifies all expressions into assignees,
uses or both.
span_errin liveness analysis, which are now borrowck'sresponsibilities.
Closes #12527.