Fix typos with repeated words #12727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
@alexcrichton et al.: https://github.com/huonw/spellck, and it even includes a list of known false positives (i.e. differences to my local I guess it could be extended to look for basic grammar issues like doubled words etc. (although there's the problem that that also has false positives, so if we do do it, it needs a list too). |
|
(Also, this needs a rebase.) |
|
One could check the spelling and grammar in a word processor, via pandoc. |
|
@kud1ing that's a good idea, but doing it quickly (i.e. in an automated fashion, even just to get a list of lines with incorrect words in a crate) seems like it might be tricky. |
bors
added a commit
that referenced
this pull request
Mar 6, 2014
Cosmetic changes at best, but there are so many such typos that I couldn't ignore them. :) Some occurrences of typos are linked to the generated documentations but no changes should break the builds.
| @@ -284,7 +284,7 @@ pub struct PoolConfig { | |||
| } | |||
|
|
|||
| impl PoolConfig { | |||
| /// Returns the default configuration, as determined the the environment | |||
| /// Returns the default configuration, as determined the environment | |||
There was a problem hiding this comment.
should be "by the environment".
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 25, 2022
…eld-name, r=jonas-schievink fix: Improve suggested names for extracted variables When extracting a field expression, if RA was unable to resolve the type of the field, we would previously fall back to using "var_name" as the variable name. Now, when the `Expr` being extracted matches a `FieldExpr`, we can use the `NameRef`'s ident token as a fallback option. fixes rust-lang#10035
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cosmetic changes at best, but there are so many such typos that I couldn't ignore them. :) Some occurrences of typos are linked to the generated documentations but no changes should break the builds.