Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 9 pull requests #127174

Merged
merged 21 commits into from
Jun 30, 2024
Merged

Rollup of 9 pull requests #127174

merged 21 commits into from
Jun 30, 2024

Commits on Jun 24, 2024

  1. Fix simd_gather documentation

    There is no idx in the function signature.
    betelgeuse committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    dbf7018 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. Remove the box_pointers lint.

    As the comment says, this lint "is mostly historical, and not
    particularly useful". It's not worth keeping it around.
    nnethercote committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    c053e89 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. Update the LoongArch target documentation

    The docs for the LoongArch targets are a bit dated since their
    introduction, and the prose has some room for improvement as well.
    Streamline a bit, referring to the neighboring targets' docs, and
    provide up-to-date information as much as I can come up with.
    xen0n committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    64be3a3 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2024

  1. small correction to fmt::Pointer impl

    the `expose_provenance` method does not require `T: Sized`
    Sky9x committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    35f2093 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2024

  1. Configuration menu
    Copy the full SHA
    617de8c View commit details
    Browse the repository at this point in the history
  2. Replace a magic boolean with enum DeclareLetBindings

    The new enum `DeclareLetBindings` has three variants:
    - `Yes`: Declare `let` bindings as normal, for `if` conditions.
    - `No`: Don't declare bindings, for match guards and let-else.
    - `LetNotPermitted`: Assert that `let` expressions should not occur.
    Zalathar committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    ad575b0 View commit details
    Browse the repository at this point in the history
  3. Replace a magic boolean with enum EmitStorageLive

    The previous boolean used `true` to indicate that storage-live should _not_ be
    emitted, so all occurrences of `Yes` and `No` should be the logical opposite of
    the previous value.
    Zalathar committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    3b22589 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ed07712 View commit details
    Browse the repository at this point in the history
  5. coverage: Avoid getting extra unexpansion info when we don't need it

    These particular callers don't actually use the returned macro information, so
    they can use a simpler span-unexpansion function that doesn't return it.
    Zalathar committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    6c33149 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    4b516f5 View commit details
    Browse the repository at this point in the history
  7. Add a regression test for rust-lang#123630

    compiler should not suggest nonsensical signatures, original suggestion was
    
    error[E0308]: mismatched types
     --> src/lib.rs:3:31
      |
    3 | fn select<F, I>(filter: F) -> Select<F, I> {
      |    ------                     ^^^^^^^^^^^^ expected `Select<F, I>`, found `()`
      |    |
      |    implicitly returns `()` as its body has no tail or `return` expression
      |
      = note: expected struct `Select<F, I>`
              found unit type `()`
    
    error[E0282]: type annotations needed for `Select<{closure@src/lib.rs:8:22: 8:25}, I>`
     --> src/lib.rs:8:9
      |
    8 |     let lit = select(|x| match x {
      |         ^^^
      |
    help: consider giving `lit` an explicit type, where the type for type parameter `I` is specified
      |
    8 |     let lit: Select<{closure@src/lib.rs:8:22: 8:25}, I> = select(|x| match x {
      |            ++++++++++++++++++++++++++++++++++++++++++++
    
    Some errors have detailed explanations: E0282, E0308.
    For more information about an error, try `rustc --explain E0282`.
    pacak committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    8a0e1ab View commit details
    Browse the repository at this point in the history
  8. Update test comment

    BoxyUwU committed Jun 30, 2024
    Configuration menu
    Copy the full SHA
    f79bf19 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#126018 - nnethercote:rm-box_pointers-lint, …

    …r=lcnr
    
    Remove the `box_pointers` lint.
    
    As the comment says, this lint "is mostly historical, and not particularly useful". It's not worth keeping it around.
    
    r? ``@estebank``
    matthiaskrgr authored Jun 30, 2024
    Configuration menu
    Copy the full SHA
    6f57655 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#126895 - betelgeuse:improve_simd_gather_doc…

    …umentation, r=Amanieu
    
    Fix simd_gather documentation
    
    There is no idx in the function signature.
    matthiaskrgr authored Jun 30, 2024
    Configuration menu
    Copy the full SHA
    5f43a89 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#126981 - Zalathar:enums, r=Nadrieril

    Replace some magic booleans in match-lowering with enums
    
    This PR takes some boolean arguments used by the match-lowering code, and replaces them with dedicated enums that more clearly express their effect, while also making it much easier to find how each value is ultimately used.
    matthiaskrgr authored Jun 30, 2024
    Configuration menu
    Copy the full SHA
    d404ce7 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#127038 - BoxyUwU:reword_comment, r=camelid

    Update test comment
    
    r? `@camelid`
    
    Rewrote this comment since it mixed up a/b in one place and was generally a bit confusing
    matthiaskrgr authored Jun 30, 2024
    Configuration menu
    Copy the full SHA
    1fac8de View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#127053 - xen0n:update-loong-docs, r=Nilstri…

    …eb,heiher
    
    Update the LoongArch target documentation
    
    The docs for the LoongArch targets are a bit dated since their introduction, and the prose has some room for improvement as well. Streamline a bit, referring to the neighboring targets' docs, and provide up-to-date information as much as I can come up with.
    
    cc fellow target maintainer `@heiher` for review of target-specific bits
    matthiaskrgr authored Jun 30, 2024
    Configuration menu
    Copy the full SHA
    7e05bc3 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#127069 - Sky9x:fmt-pointer-use-addr, r=Nils…

    …trieb
    
    small correction to fmt::Pointer impl
    
    ~~The `addr` method does not require `T: Sized`, and is preferred for use over `expose_provenance`.~~
    `expose_provenance` does not require `T: Sized`.
    matthiaskrgr authored Jun 30, 2024
    Configuration menu
    Copy the full SHA
    7a43417 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#127157 - Zalathar:unexpand, r=cjgillot

    coverage: Avoid getting extra unexpansion info when we don't need it
    
    Several callers of `unexpand_into_body_span_with_visible_macro` would immediately discard the additional macro-related information, which is wasteful. We can avoid this by having them instead call a simpler method that just returns the span they care about.
    
    This PR also moves the relevant functions out of `coverage::spans::from_mir` and into a new submodule `coverage::unexpand`, so that calling them from `coverage::mappings` is less awkward.
    
    There should be no actual changes to coverage-instrumentation output, as demonstrated by the absence of test updates.
    matthiaskrgr authored Jun 30, 2024
    Configuration menu
    Copy the full SHA
    b2aebc1 View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#127160 - pacak:123630-test, r=Nadrieril

    Add a regression test for rust-lang#123630
    
    Fixes rust-lang#123630
    
    compiler should not suggest nonsensical signatures, original suggestion was
    
    ```
    error[E0308]: mismatched types
     --> src/lib.rs:3:31
      |
    3 | fn select<F, I>(filter: F) -> Select<F, I> {
      |    ------                     ^^^^^^^^^^^^ expected `Select<F, I>`, found `()`
      |    |
      |    implicitly returns `()` as its body has no tail or `return` expression
      |
      = note: expected struct `Select<F, I>`
              found unit type `()`
    
    error[E0282]: type annotations needed for `Select<{closure@src/lib.rs:8:22: 8:25}, I>`
     --> src/lib.rs:8:9
      |
    8 |     let lit = select(|x| match x {
      |         ^^^
      |
    help: consider giving `lit` an explicit type, where the type for type parameter `I` is specified
      |
    8 |     let lit: Select<{closure@src/lib.rs:8:22: 8:25}, I> = select(|x| match x {
      |            ++++++++++++++++++++++++++++++++++++++++++++
    
    Some errors have detailed explanations: E0282, E0308. For more information about an error, try `rustc --explain E0282`.
    ```
    matthiaskrgr authored Jun 30, 2024
    Configuration menu
    Copy the full SHA
    6335b83 View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#127161 - GuillaumeGomez:improve-run-make-ar…

    …gs, r=Kobzol
    
    Improve `run-make-support` library `args` API
    
    It allows to pass both `Vec` and slices, which makes it much better (for me at least 😉).
    
    r? ``@Kobzol``
    matthiaskrgr authored Jun 30, 2024
    Configuration menu
    Copy the full SHA
    4037197 View commit details
    Browse the repository at this point in the history