-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate remap-path-prefix
, debug-assertions
and emit-stack-sizes
run-make
tests to rmake
#126801
Conversation
The run-make-support library was changed cc @jieyouxu This PR modifies cc @jieyouxu |
This comment has been minimized.
This comment has been minimized.
656928e
to
88c4431
Compare
This comment has been minimized.
This comment has been minimized.
88c4431
to
2931afd
Compare
@bors try |
Migrate `remap-path-prefix`, `debug-assertions` and `emit-stack-sizes` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). Needs OSX/MSVC try jobs. try-job: aarch64-apple try-job: x86_64-msvc
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
2931afd
to
2baf8ed
Compare
The only change made was restoring the ignore-directives previously featured in the Makefile test, with added Reason comment. @rustbot review |
@bors try |
Migrate `remap-path-prefix`, `debug-assertions` and `emit-stack-sizes` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). Needs OSX/MSVC try jobs. try-job: aarch64-apple try-job: x86_64-msvc
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
98ff8fe
to
2e1fd8f
Compare
I just gave it a shot. Though this is a temporary solution, I'd like to make a new PR after this one that replaces all instances of @rustbot review |
Thanks! I assume that @bors try |
Migrate `remap-path-prefix`, `debug-assertions` and `emit-stack-sizes` `run-make` tests to rmake Part of rust-lang#121876 and the associated [Google Summer of Code project](https://blog.rust-lang.org/2024/05/01/gsoc-2024-selected-projects.html). Needs OSX/MSVC try jobs. try-job: aarch64-apple try-job: x86_64-msvc
I don't know, the normalization-backslash fix hasn't been tried yet. We're about to see. |
☀️ Try build successful - checks-actions |
2e1fd8f
to
1795082
Compare
@bors r+ rollup=iffy |
r? Kobzol |
☀️ Test successful - checks-actions |
Finished benchmarking commit (d1b7355): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults (secondary 8.2%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 698.422s -> 697.982s (-0.06%) |
Part of #121876 and the associated Google Summer of Code project.
Needs OSX/MSVC try jobs.
try-job: aarch64-apple
try-job: x86_64-msvc