std: add reserve_additional and an Extendable impl to Vec. #12673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add some tests? It's not a huge issue, but it would be nice. |
| @@ -125,6 +125,15 @@ impl<T> FromIterator<T> for Vec<T> { | |||
| vector | |||
| } | |||
| } | |||
There was a problem hiding this comment.
missing a newline here :)
|
@Aatch: I think this stuff does already have tests for |
|
@thestinger I didn't realise that weren't actually any tests in |
|
Now comes with free tests! (Don't miss out. Call now to place your order.) |
bors
added a commit
that referenced
this pull request
Mar 3, 2014
std: add reserve_additional and an Extendable impl to Vec.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 18, 2024
…rs, r=blyxyas [`ptr_as_ptr`]: Fix duplicate diagnostics Relates to rust-lang/rust-clippy#12379 `ptr_as_ptr::check` is called twice in `clippy_lints/src/casts/mod.rs` --- changelog: [`ptr_as_ptr`]: Fix duplicate diagnostics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std: add reserve_additional and an Extendable impl to Vec.