Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some non-essential trait re-exports from the prelude. #12485

Closed
wants to merge 3 commits into from

Conversation

brendanzab
Copy link
Member

Default only contains a static method. It provides no extension methods that are commonly used in client code.

FromStr already has its only static method, from_str, re-exported in the prelude. Implementing the trait itself is less common.

ToStrRadix is being phased out in favor of using std::fmt::radix, and the to_str_radix method is rather specialised to warrant a global re-export.

r? @brson

@huonw
Copy link
Member

huonw commented Feb 23, 2014

FWIW, IterBytes is going to be completely removed, pending a snapshot. (Doesn't mean it can't disappear from the prelude now, though.)

@brendanzab
Copy link
Member Author

Cheers @huonw, updated the PR description.

@brendanzab
Copy link
Member Author

rebased

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants