Add const generics support for pattern types #123689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
HIR ty lowering was modified cc @fmease |
oli-obk
reviewed
Apr 9, 2024
spastorino
force-pushed
the
pattern_types_const_generics
branch
from
3bd2744
to
f7b9e47
Compare
fmease
requested changes
Apr 9, 2024
| res: Res::Def(DefKind::ConstParam, def_id), .. | ||
| }, | ||
| )) => { | ||
| let ty = tcx.type_of(def_id).instantiate_identity(); |
There was a problem hiding this comment.
Suggested change
| let ty = tcx.type_of(def_id).instantiate_identity(); | |
| let ty = tcx.type_of(def_id).no_bound_vars().expect("const parameter types cannot be generic"); |
There was a problem hiding this comment.
Ideally we would factor out the logic common between this code path here and lower_const_param 🤔, not blocking though
There was a problem hiding this comment.
Slowly wondering if we should just use entirely new hir nodes so we can just use AnonConst like other type system consts
spastorino
force-pushed
the
pattern_types_const_generics
branch
from
f7b9e47
to
30c546a
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 10, 2024
…llaumeGomez Rollup of 7 pull requests Successful merges: - rust-lang#118391 (Add `REDUNDANT_LIFETIMES` lint to detect lifetimes which are semantically redundant) - rust-lang#123534 (Windows: set main thread name without re-encoding) - rust-lang#123659 (Add support to intrinsics fallback body) - rust-lang#123689 (Add const generics support for pattern types) - rust-lang#123701 (Only assert for child/parent projection compatibility AFTER checking that theyre coming from the same place) - rust-lang#123702 (Further cleanup cfgs in the UI test suite) - rust-lang#123706 (rustdoc: reduce per-page HTML overhead) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 10, 2024
Rollup merge of rust-lang#123689 - spastorino:pattern_types_const_generics, r=oli-obk Add const generics support for pattern types r? `@oli-obk`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 11, 2024
…, r=compiler-errors Call lower_const_param instead of duplicating the code Follow up of rust-lang#123689 r? `@oli-obk` I had this commit in my old branch that I had forgotten about, `@fmease` pointed about this in rust-lang#123689 I've left the branches that are not `Range` as do nothing as that's what we are currently doing but maybe we want to err or something.
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 11, 2024
Rollup merge of rust-lang#123738 - spastorino:reuse-lower-const-param, r=compiler-errors Call lower_const_param instead of duplicating the code Follow up of rust-lang#123689 r? `@oli-obk` I had this commit in my old branch that I had forgotten about, `@fmease` pointed about this in rust-lang#123689 I've left the branches that are not `Range` as do nothing as that's what we are currently doing but maybe we want to err or something.
fmease
reviewed
Apr 12, 2024
| &hir::Path { | ||
| res: Res::Def(DefKind::ConstParam, def_id), .. | ||
| }, | ||
| )) => { |
There was a problem hiding this comment.
Note that we're missing a call to prohibit_generic_args here. Right now, we permit:
pattern_type!(u32 is START::<(), i32, 2>..=END::<_>)where START and END are u32s like in the UI test.
While we could add this check, this just reinforces oli's point: #123689 (comment), Zulip discussion.
There was a problem hiding this comment.
Just noticed this while reviewing an unrelated PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @oli-obk