-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
propagate --target
only if target is not host
#123593
Conversation
rustbot has assigned @Mark-Simulacrum. Use |
This comment has been minimized.
This comment has been minimized.
Passing `--target` alters `RUSTFLAGS` in the build scripts. Since there is no reason to pass them when building for the host triple, exclude them if the target is the host triple. Signed-off-by: onur-ozkan <[email protected]>
9f65115
to
0bdcd2c
Compare
This comment has been minimized.
This comment has been minimized.
Signed-off-by: onur-ozkan <[email protected]>
The job Click to see the possible cause of the failure (guessed by this bot)
|
|
|
I thought that removing the target flag would be an easy workaround for the host Closing the PR. |
Passing
--target
altersRUSTFLAGS
in the build scripts. Since there is no reason to pass them when building for the host triple, exclude them if the target is the host triple.To test this PR, apply this patch:
Then, run
RUSTFLAGS_NOT_BOOTSTRAP='--cfg=foo --check-cfg=cfg(foo) -Zunstable-options' x build miri
.Partially resolves #94007.