-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 9 pull requests #122966
Rollup of 9 pull requests #122966
Conversation
Given `'hello world'` and `'1 str', provide a structured suggestion for a valid string literal: ``` error[E0762]: unterminated character literal --> $DIR/lex-bad-str-literal-as-char-3.rs:2:26 | LL | println!('hello world'); | ^^^^ | help: if you meant to write a `str` literal, use double quotes | LL | println!("hello world"); | ~ ~ ``` ``` error[E0762]: unterminated character literal --> $DIR/lex-bad-str-literal-as-char-1.rs:2:20 | LL | println!('1 + 1'); | ^^^^ | help: if you meant to write a `str` literal, use double quotes | LL | println!("1 + 1"); | ~ ~ ``` Fix rust-lang#119685.
…E: IndexMap: key not found Fixes rust-lang#104779
…y using files for arguments if there are too many
regression test for rust-lang#103626 I don't know what a descriptive filename for this would be. Fixes rust-lang#103626
…xxxx, r=fmease add a couple more ice tests Fixes rust-lang#104779 Fixes rust-lang#106423 Fixes rust-lang#106444 Fixes rust-lang#101852 Fixes rust-lang#106874 Fixes rust-lang#105047 Fixes rust-lang#107228 Fixes rust-lang#99945
core/panicking: fix outdated comment Looks like this function got renamed/changed at some point and the comment did not get updated. r? `@m-ou-se`
@bors r+ rollup=never p=9 |
whoops. |
☀️ Test successful - checks-actions |
📌 Perf builds for each rolled up PR:
previous master: 9b8d12cf4c In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Finished benchmarking commit (548e14b): comparison URL. Overall result: ❌ regressions - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 669.289s -> 669.812s (0.08%) |
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#121281 (regression test for rust-lang#103626) - rust-lang#122168 (Fix validation on substituted callee bodies in MIR inliner) - rust-lang#122217 (Handle str literals written with `'` lexed as lifetime) - rust-lang#122379 (transmute: caution against int2ptr transmutation) - rust-lang#122840 (`rustdoc --test`: Prevent reaching the maximum size of command-line by using files for arguments if there are too many) - rust-lang#122907 (Uniquify `ReError` on input mode in canonicalizer) - rust-lang#122942 (Add test in higher ranked subtype) - rust-lang#122943 (add a couple more ice tests) - rust-lang#122963 (core/panicking: fix outdated comment) r? `@ghost` `@rustbot` modify labels: rollup
The regressions are probably too small here for us to need to dig much deeper. @rustbot label: +perf-regression-triaged |
Successful merges:
'
lexed as lifetime #122217 (Handle str literals written with'
lexed as lifetime)rustdoc --test
: Prevent reaching the maximum size of command-line by using files for arguments if there are too many #122840 (rustdoc --test
: Prevent reaching the maximum size of command-line by using files for arguments if there are too many)ReError
on input mode in canonicalizer #122907 (UniquifyReError
on input mode in canonicalizer)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup