Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use bold magenta instead of bold white for highlighting #118756

Merged
merged 3 commits into from
Dec 12, 2023

Commits on Dec 8, 2023

  1. Configuration menu
    Copy the full SHA
    9f0c6f1 View commit details
    Browse the repository at this point in the history
  2. use magenta instead of bold for highlighting

    according to a poll of gay people in my phone, purple is the most popular color to use for highlighting
    
    | color      | percentage |
    | ---------- | ---------- |
    | bold white | 6%         |
    | blue       | 14%        |
    | cyan       | 26%        |
    | purple     | 37%        |
    | magenta    | 17%        |
    
    unfortunately, purple is not supported by 16-color terminals, which rustc apparently wants to support for some reason.
    until we require support for full 256-color terms (e.g. by doing the same feature detection as we currently do for urls), we can't use it.
    
    instead, i have collapsed the purple votes into magenta on the theory that they're close, and also because magenta is pretty.
    jyn514 committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    96b027f View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2023

  1. use different revisions for testing colors on windows

    this is kinda jank because it means people need both machines to bless the tests
    jyn514 committed Dec 9, 2023
    Configuration menu
    Copy the full SHA
    32e48fc View commit details
    Browse the repository at this point in the history