-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cargo #114364
Update cargo #114364
Conversation
Some changes occurred in src/tools/cargo cc @ehuss |
Feel pretty safe to include this in a rollup. We'll see. @bors r+ rollup=always |
Update cargo 8 commits in c91a693e7977e33a1064b63a5daf5fb689f01651..6dc1deaddf62c7748c9097c7ea88e9ec77ff1a1a 2023-07-31 00:26:46 +0000 to 2023-08-02 00:23:54 +0000 - `#[allow(internal_features)]` in RUSTC_BOOTSTRAP test (rust-lang/cargo#12429) - ci: rewrite bump check and respect semver (rust-lang/cargo#12395) - fix(update): Tweak CLI behavior (rust-lang/cargo#12428) - chore(deps): update compatible (rust-lang/cargo#12426) - Display crate version on timings graph (rust-lang/cargo#12420) - chore(deps): update alpine docker tag to v3.18 (rust-lang/cargo#12427) - Use thiserror for credential provider errors (rust-lang/cargo#12424) - Clarify in `--help` that `cargo test --all-targets` excludes doctests (rust-lang/cargo#12422) r? `@ghost`
Update cargo 8 commits in c91a693e7977e33a1064b63a5daf5fb689f01651..6dc1deaddf62c7748c9097c7ea88e9ec77ff1a1a 2023-07-31 00:26:46 +0000 to 2023-08-02 00:23:54 +0000 - `#[allow(internal_features)]` in RUSTC_BOOTSTRAP test (rust-lang/cargo#12429) - ci: rewrite bump check and respect semver (rust-lang/cargo#12395) - fix(update): Tweak CLI behavior (rust-lang/cargo#12428) - chore(deps): update compatible (rust-lang/cargo#12426) - Display crate version on timings graph (rust-lang/cargo#12420) - chore(deps): update alpine docker tag to v3.18 (rust-lang/cargo#12427) - Use thiserror for credential provider errors (rust-lang/cargo#12424) - Clarify in `--help` that `cargo test --all-targets` excludes doctests (rust-lang/cargo#12422) r? ``@ghost``
something's messed up in rustix on loongarch: #114367 (comment) |
Sorry @Nilstrieb. I thought it was safe to help unblock your PR. I'll take a look then. |
https://github.com/rust-lang/libc/blob/28ab9b9e7bd04a5c5aca3f4d78583214f63d4002/src/unix/linux_like/linux/gnu/b64/loongarch64/mod.rs#L322 libc does indeed not have SYS_open for loongarch64 |
this was fixed in bytecodealliance/rustix#751 |
@heiher could you help fix this? EDIT: guess just need a rustix bump. |
Yeah. I think we just need a new release of rustix. |
Update rustix to 0.38.6 ### What does this PR try to resolve? Resolve build breaks for LoongArch: rust-lang/rust#114364 ### How should we test and review this PR? ```bash cargo build --target=loongarch64-unknown-linux-gnu ``` ### Additional information None
Thanks everyone. Let's do it again. @bors r+ p=1 rollup=never |
☀️ Test successful - checks-actions |
☀️ Test successful - checks-actions |
Finished benchmarking commit (8131b97): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 648.281s -> 647.939s (-0.05%) |
10 commits in c91a693e7977e33a1064b63a5daf5fb689f01651..020651c52257052d28f6fd83fbecf5cfa1ed516c
2023-07-31 00:26:46 +0000 to 2023-08-02 16:00:37 +0000
master
branch by default branch in documentation (replacemaster
branch by default branch in documentation cargo#12435)#[allow(internal_features)]
in RUSTC_BOOTSTRAP test (#[allow(internal_features)]
in RUSTC_BOOTSTRAP test cargo#12429)--help
thatcargo test --all-targets
excludes doctests (Clarify in--help
thatcargo test --all-targets
excludes doctests cargo#12422)r? @ghost